Skip to content

BitWindow orchestrator core & sidechains (1 of 2): 15 fixes from a security review - #2140

Open
giaki3003 wants to merge 15 commits into
LayerTwo-Labs:masterfrom
giaki3003:fix/w5-area-orch-core-1
Open

giaki3003 wants to merge 15 commits into
LayerTwo-Labs:masterfrom
giaki3003:fix/w5-area-orch-core-1

Conversation

@giaki3003

Copy link
Copy Markdown
Contributor

A set of 15 independent fixes to the BitWindow orchestrator core & sidechains, stacked on one branch so they can be reviewed together and cherry-picked individually. Based on current master; the branch builds and its tests pass at the tip (39 files changed, 1929 insertions(+), 115 deletions(-)).

Fixes (oldest first)

  • 4a405c208 CoinShift typed Claim, Status, and Update send an undecodable SwapId
  • b6e47541e Truthcoin typed market create, buy, and sell calls fail at the JSON-RPC boundary
  • fce3b36f9 Network rewrite drops all but final Bitcoin Core peer
  • e7de9eb53 Sidechain launch ignores selected network and defaults to Signet
  • 294d5b5f1 no-Core eCash reverse switch commits onto its still-barred target branch
  • 81b3d9c36 cross-network eCash adoption skips the required Core rewind
  • b2e72cb95 BitWindow ships a stale enforcer option that prevents startup
  • 8f249f3d9 Orchestrator shared CoreStatusClient can misroute concurrent wallet RPCs
  • 47ae0cfd5 BitWindow wallet-only reset leaves bitwindow.db (unscoped SQLite tables) byte-intact, so a post-reset wallet reads prior-wallet metadata
  • f43981f05 drivechain-frontends AdoptOrphans loses ForceBackend flag for re-adopted sidechain prod PID files
  • 5b0480dc5 sidechain-orchestrator AdoptOrphans adopts unrelated process via bidirectional-substring processNameMatches, then signals wrong PID
  • 2079d1119 drivechain-frontends/sidechain-orchestrator — Reset on adopted binary wipes datadir while OS process stays alive and no restart is scheduled
  • b62d8a037 Network swap reuses the old Bitcoin Core health checker and stalls L1 restart
  • f9758655a SetElectrumServer persist failure leaves engine on new endpoint with no rollback
  • 6c81dfabb BitAssets typed transfer swaps destination and asset ID

Each commit is self-contained — git cherry-pick <sha> works for any of them. Happy to split, reorder, or drop any. Finding reports for individual fixes available on request.

giaki3003 and others added 15 commits August 30, 2026 21:30
…apId

Bug: w5-20260804-1647-kimiclaw-confirm-openclaw- (primary)
Finding: findings/20260804-1647-kimiclaw-confirm-openclaw-drivechain-frontends-coinshift-swap-id-wire-shape.md
Severity: R3-T2

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
(cherry picked from commit 618c686)
…SON-RPC boundary

Bug: w5-20260801-0852-openclaw-confirm-kimiclaw- (primary)
Finding: findings/20260801-0852-openclaw-confirm-kimiclaw-drivechain-frontends-truthcoin-market-object-param-mismatch.md
Severity: R3-T3

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
(cherry picked from commit 9b7746e)
Bug: w5-20260803-0338-kimiclaw-confirm-openclaw- (primary)
Finding: findings/20260803-0338-kimiclaw-confirm-openclaw-drivechain-frontends-network-rewrite-drops-connect-peers.md
Severity: R3-T3

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
(cherry picked from commit 9770a88)
Bug: w5-20260803-0924-kimiclaw-confirm-openclaw- (primary)
Finding: findings/20260803-0924-kimiclaw-confirm-openclaw-drivechain-frontends-sidechain-launch-ignores-network.md
Severity: R3-T3

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
(cherry picked from commit c4bd193)
…t branch

Bug: w5-20260822-1421-openclaw-confirm-glmclaw-d (primary)
Finding: findings/20260822-1421-openclaw-confirm-glmclaw-drivechain-frontends-ecash-nocore-switch-barred-chain.md
Severity: R3-T3

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
(cherry picked from commit 472123a)
Bug: w5-20260824-0504-openclaw-confirm-glmclaw-d (primary)
Finding: findings/20260824-0504-openclaw-confirm-glmclaw-drivechain-frontends-ecash-coldadopt-skips-rewind.md
Severity: R3-T3

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
(cherry picked from commit 6c618dc)
Bug: w5-20260825-1351-openclaw-confirm-kimiclaw- (primary)
Finding: findings/20260825-1351-openclaw-confirm-kimiclaw-drivechain-frontends-enforcer-conf-unknown-key-argv-brick.md
Severity: R3-T3

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
(cherry picked from commit dd6cd24)
…let RPCs

Bug: w5-20260617-1758-kimiclaw-confirm-openclaw- (primary)
Finding: findings/20260617-1758-kimiclaw-confirm-openclaw-drivechain-frontends-orchestrator-corestatus-url-race.md
Severity: R3-T4

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
(cherry picked from commit 95233c3)
…te tables) byte-intact, so a post-reset wallet reads prior-wallet metadata

Bug: w5-20260628-0440-kimiclaw-confirm-glmclaw-d (primary)
Finding: findings/20260628-0440-kimiclaw-confirm-glmclaw-drivechain-frontends-bitwindow-reset-wallet-only-leaves-unscoped-sqlite-tables.md
Severity: R3-T4

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
(cherry picked from commit 282daa4)
…re-adopted sidechain prod PID files

Bug: w5-20260718-0452-kimiclaw-confirm-glmclaw-d (primary)
Finding: findings/20260718-0452-kimiclaw-confirm-glmclaw-drivechain-frontends-orchestrator-adoptorphans-loses-forcebackend-flag.md
Severity: R3-T4

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
(cherry picked from commit a5e14a4)
…ia bidirectional-substring `processNameMatches`, then signals wrong PID

Bug: w5-20260719-0444-kimiclaw-confirm-glmclaw-d (primary)
Finding: findings/20260719-0444-kimiclaw-confirm-glmclaw-drivechain-frontends-orchestrator-adoptorphans-processnamematches-wrong-pid-signal.md
Severity: R3-T4

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
(cherry picked from commit 19f552f)
…inary wipes datadir while OS process stays alive and no restart is scheduled

Bug: w5-20260720-2141-kimiclaw-confirm-glmclaw-d (primary)
Finding: findings/20260720-2141-kimiclaw-confirm-glmclaw-drivechain-frontends-orchestrator-reset-adopted-wipes-datadir-no-kill-no-restart.md
Severity: R3-T4

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
(cherry picked from commit 637c77e)
…ls L1 restart

Bug: w5-20260727-1100-kimiclaw-confirm-openclaw- (primary)
Finding: findings/20260727-1100-kimiclaw-confirm-openclaw-drivechain-frontends-network-swap-stale-monitor.md
Severity: R3-T4

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
(cherry picked from commit d881107)
…with no rollback

Bug: w5-20260729-1047-kimiclaw-confirm-glmclaw-d (primary)
Finding: findings/20260729-1047-kimiclaw-confirm-glmclaw-drivechain-frontends-setelectrumserver-persist-fail-no-rollback.md
Severity: R3-T4

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
(cherry picked from commit bff2a51)
Bug: w5-20260801-0500-kimiclaw-confirm-openclaw- (primary)
Finding: findings/20260801-0500-kimiclaw-confirm-openclaw-drivechain-frontends-bitassets-transfer-param-order.md
Severity: R3-T4

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
(cherry picked from commit fd12d65)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant