Conversation
…ets `CreateCpfp` spend an already-confirmed parent Bug: w5-20260727-2143-kimiclaw-confirm-openclaw- (primary) Finding: findings/20260727-2143-kimiclaw-confirm-openclaw-drivechain-frontends-electrum-outage-cpfp-confirmed-parent.md Severity: R3-T2 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> (cherry picked from commit 3c472d4)
Bug: w5-20260617-2033-kimiclaw-confirm-openclaw- (primary) Finding: findings/20260617-2033-kimiclaw-confirm-openclaw-drivechain-frontends-bip47-feature-byte-ignored.md Severity: R3-T4 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> (cherry picked from commit e389f64)
…ly locks wallet Bug: w5-20260620-2233-kimiclaw-confirm-glmclaw-d (primary) Finding: findings/20260620-2233-kimiclaw-confirm-glmclaw-drivechain-frontends-bitwindow-changepassword-nonatomic-wallet-metadata-write.md Severity: R3-T4 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> (cherry picked from commit d44b457)
Bug: w5-20260622-1925-glmclaw-confirm-kimiclaw-d (primary) Finding: findings/20260622-1925-glmclaw-confirm-kimiclaw-drivechain-frontends-delete-wallet-core-leak.md Severity: R3-T4 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> (cherry picked from commit d0bead9)
Bug: w5-20260712-1245-kimiclaw-confirm-openclaw- (primary) Finding: findings/20260712-1245-kimiclaw-confirm-openclaw-drivechain-frontends-electrum-server-switch-http-validator.md Severity: R3-T4 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> (cherry picked from commit e6fcac6)
…d and misses the requested package rate Bug: w5-20260713-2145-openclaw-confirm-kimiclaw- (primary) Finding: findings/20260713-2145-openclaw-confirm-kimiclaw-drivechain-frontends-cpfp-bip47-parent-input-vsize-underpay.md Severity: R3-T4 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> (cherry picked from commit 90340b4)
Bug: w5-20260728-0431-kimiclaw-confirm-openclaw- (primary) Finding: findings/20260728-0431-kimiclaw-confirm-openclaw-drivechain-frontends-fixed-watch-descriptor-range.md Severity: R3-T4 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> (cherry picked from commit 7dddfe2)
…start that unloads `load_on_startup=false` Core wallets Bug: w5-20260804-0017-kimiclaw-confirm-glmclaw-d (primary) Finding: findings/20260804-0017-kimiclaw-confirm-glmclaw-drivechain-frontends-orchestrator-corewallets-cache-survives-bitcoind-restart-unload.md Severity: R3-T4 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> (cherry picked from commit 6a9b079)
Bug: w5-20260810-0946-kimiclaw-confirm-openclaw- (primary) Finding: findings/20260810-0946-kimiclaw-confirm-openclaw-drivechain-frontends-bip47-reserved-byte-state-split.md Severity: R3-T4 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> (cherry picked from commit 2d8c6df)
Bug: w5-20260814-2152-openclaw-confirm-glmclaw-d (primary) Finding: findings/20260814-2152-openclaw-confirm-glmclaw-drivechain-frontends-restored-sidechain-starter-now.md Severity: R3-T4 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> (cherry picked from commit 633eec1)
Bug: w5-20260820-1852-openclaw-confirm-kimiclaw- (primary) Finding: findings/20260820-1852-openclaw-confirm-kimiclaw-drivechain-frontends-orchestrator-lock-notify-stale-stream.md Severity: R3-T4 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> (cherry picked from commit abdd0fd)
…eive Bug: w5-20260822-1254-openclaw-confirm-kimiclaw- (primary) Finding: findings/20260822-1254-openclaw-confirm-kimiclaw-drivechain-frontends-core-watchonly-taproot-default-receive-kind.md Severity: R3-T4 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> (cherry picked from commit 628c64f)
…er account is watched Bug: w5-20260822-2004-openclaw-confirm-glmclaw-d (primary) Finding: findings/20260822-2004-openclaw-confirm-glmclaw-drivechain-frontends-migration-firstboot-network-companion-blind.md Severity: R3-T4 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> (cherry picked from commit a3f2d5a)
…r a concurrent swap Bug: w5-20260822-2058-openclaw-confirm-glmclaw-d (primary) Finding: findings/20260822-2058-openclaw-confirm-glmclaw-drivechain-frontends-deposit-record-network-swap-misfile.md Severity: R3-T4 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> (cherry picked from commit aa90d0b)
…r wallet Bug: w5-20260829-0149-openclaw-confirm-glmclaw-d (primary) Finding: findings/20260829-0149-openclaw-confirm-glmclaw-drivechain-frontends-testnet-enforcer-migration-panic.md Severity: R3-T4 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> (cherry picked from commit 87107b8)
…re core fake
Two independently-correct fixes meet in wallet/core_backend_test.go:
- "DeleteWallet leaves Core wallet loaded" adds CoreBackend.Forget and
TestCoreBackendForgetUnloadsWallet, whose stub answers unloadwallet with
an empty result.
- "coreWallets cache survives bitcoind restart" rewrites stubEnsureFlow into
a stateful fake: listwallets reports what createwallet/loadwallet actually
loaded, and createwallet refuses a wallet already on disk. Ensure now
confirms a cached wallet is still loaded before serving it.
Under the load-aware fake, the Forget test's unloadwallet stub left the wallet
recorded as loaded and on disk, so the second Ensure found it still present,
took the adopt path, and called an unstubbed listdescriptors instead of
re-creating the wallet from scratch as the test asserts.
Forget both unloads the wallet and moves its directory aside, so model that in
the stub: drop the wallet from the fake's loaded and on-disk sets. Test-only;
neither fix's behaviour changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A set of 15 independent fixes to the BitWindow orchestrator wallet, stacked on one branch so they can be reviewed together and cherry-picked individually. Based on current
master; the branch builds and its tests pass at the tip (25 files changed, 1168 insertions(+), 89 deletions(-)).Fixes (oldest first)
7bbfcd550drivechain-frontendsElectrumBackendcachedScantip outage letsCreateCpfpspend an already-confirmed parentda2bbfc07BIP47 feature byte 79 is accepted but ignored during sends1b21ca1a1ChangePassword non-atomic wallet/metadata write window permanently locks walletd119270c1sidechain-orchestratorDeleteWalletleaves Core wallet loaded650e97034Mainnet Electrum server switching rejects every Electrum endpoint47626fb4eCPFP sizes a BIP47 P2PKH parent input as the wallet's P2WPKH kind and misses the requested package ratec8a398eb7Fixed watch-only descriptors are imported with an invalid rangeaa5e02239orchestrator WalletEngine.coreWallets cache survives bitcoind restart that unloadsload_on_startup=falseCore walletsa0d7db223BIP47 reserved-byte aliases split state and reuse payment addressesb3cee69bcrestored Core-derived sidechain starter is imported at"now"ec7b848a0Orchestrator wallet lock omits stream state notificationc2b494332Core watch-only taproot descriptor defaults to native-segwit receivea183758bafirst upgraded network permanently selects whether legacy enforcer account is watcheda6aa696c5CreateDeposit records can be filed under the target network after a concurrent swap1facbfdc3testnet startup panics while migrating a matching legacy enforcer walletReconciliation
One commit reconciles fixes that each pass alone but interact when combined (kept every fix; the change is minimal and additive):
449f328b0reconcile orch-wallet — Forget test stub must clear the load-aware core fakeEach commit is self-contained —
git cherry-pick <sha>works for any of them. Happy to split, reorder, or drop any. Finding reports for individual fixes available on request.