Conversation
…ltisig DeleteGroup deletes only the parent multisig_groups row and orphans the group's signed-PSBT transactions; recreating or importing a group with the same client-supplied ID then inherits the deleted group's pending multisig spend (destination/amount/signed PSBT) Bug: w5-20260613-1215-claudeclaw-confirm-bitwind (primary) Finding: findings/20260613-1215-claudeclaw-confirm-bitwindow-multisig-delete-orphans-tx-fk-off-reused-group-id.md Severity: R3-T4 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> (cherry picked from commit dcf7a4b)
…/height and is never invalidated on reorg, so ListFiles/GetFile keep serving a file whose source OP_RETURN/timestamp transaction was orphaned by a mainchain reorg as if still confirmed Bug: w5-20260614-1730-claudeclaw-confirm-kimicla (primary) Finding: findings/20260614-1730-claudeclaw-confirm-kimiclaw-bitwindow-bitdrive-files-reorg-stale.md Severity: R3-T4 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> (cherry picked from commit 0afdf29)
…l rows from malformed-hash fw1 response Bug: w5-20260630-0156-kimiclaw-confirm-glmclaw-d (primary) Finding: findings/20260630-0156-kimiclaw-confirm-glmclaw-drivechain-frontends-bitwindow-sidechainmonitor-malformed-hash-orphan-row.md Severity: R3-T4 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> (cherry picked from commit 9f73f94)
…-> 0-conf destination hidden -> wait timeout -> plan cancelled next tick, remaining hops dropped Bug: w5-20260731-1633-kimiclaw-confirm-glmclaw-d (primary) Finding: findings/20260731-1633-kimiclaw-confirm-glmclaw-drivechain-frontends-bitwindow-deniability-core-minconf-default-cancels-plan.md Severity: R3-T4 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> (cherry picked from commit 8e46905)
…ing replay Bug: w5-20260822-1158-glmclaw-confirm-openclaw-d (primary) Finding: findings/20260822-1158-glmclaw-confirm-openclaw-drivechain-frontends-midreplay-mixed-ancestry.md Severity: R3-T4 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> (cherry picked from commit e439866)
Bug: w5-20260828-1444-openclaw-confirm-glmclaw-d (primary) Finding: findings/20260828-1444-openclaw-confirm-glmclaw-drivechain-frontends-restorebackup-existing-wallet-errunread.md Severity: R3-T4 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> (cherry picked from commit 36d1caf)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A set of 6 independent fixes to the BitWindow server engines & database, stacked on one branch so they can be reviewed together and cherry-picked individually. Based on current
master; the branch builds and its tests pass at the tip (16 files changed, 556 insertions(+), 21 deletions(-)).Fixes (oldest first)
13834c8e0BitWindow opens its SQLite database with foreign_keys OFF, so multisig DeleteGroup deletes only the parent multisig_groups row and orphans the group's signed-PSBT transactions; recreating or importing a group with the same client-supplied ID then inherits the deleted group's pending multisig spend (destination/amount/signed PSBT)972f56e07BitWindow's bitdrive_files table stores no confirming block hash/height and is never invalidated on reorg, so ListFiles/GetFile keep serving a file whose source OP_RETURN/timestamp transaction was orphaned by a mainchain reorg as if still confirmedf7dd4e949BitWindowSidechainMonitorEngineorphan pending fast-withdrawal rows from malformed-hash fw1 response610f312b5BitWindow DeniabilityEngine Core-path listunspent omits minconf -> 0-conf destination hidden -> wait timeout -> plan cancelled next tick, remaining hops dropped31c1f3780BitWindow accepts mixed ancestry when Core switches branches during replayde1567aa9RestoreBackup rejects every existing valid wallet with ErrUnreadEach commit is self-contained —
git cherry-pick <sha>works for any of them. Happy to split, reorder, or drop any. Finding reports for individual fixes available on request.