Conversation
…the bearer private key before any confirmation Bug: w5-20260602-0750-bitwindow-zero-conf-cheque (primary) Finding: findings/20260602-0750-bitwindow-zero-conf-cheque-marked-funded-exposes-bearer-key.md Severity: R3-T4 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> (cherry picked from commit 6a7be61)
… and wraps it to `uint32`, forwarding `0xffffffff` as `SidechainId` to the enforcer Bug: w5-20260620-0137-glmclaw-confirm-kimiclaw-d (primary) Finding: findings/20260620-0137-glmclaw-confirm-kimiclaw-drivechain-frontends-bitwindow-createdeposit-negative-slot-wrap.md Severity: R3-T4 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> (cherry picked from commit ab405d5)
…e record once funded Bug: w5-20260620-2157-glmclaw-confirm-kimiclaw-d (primary) Finding: findings/20260620-2157-glmclaw-confirm-kimiclaw-drivechain-frontends-bitwindow-createcheque-zero-expected-locks-record.md Severity: R3-T4 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> (cherry picked from commit 55c05a2)
…→ deterministic address reuse and cross-cheque fund attribution Bug: w5-20260624-1220-kimiclaw-confirm-glmclaw-d (primary) Finding: findings/20260624-1220-kimiclaw-confirm-glmclaw-drivechain-frontends-bitwindow-cheque-getnextindex-reuse-after-delete.md Severity: R3-T4 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> (cherry picked from commit 561bef7)
…pt`, leaving owner cheque row with `swept_txid = NULL` Bug: w5-20260625-0221-kimiclaw-confirm-glmclaw-d (primary) Finding: findings/20260625-0221-kimiclaw-confirm-glmclaw-drivechain-frontends-bitwindow-sweepcheque-cross-wallet-skips-updateswept.md Severity: R3-T4 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> (cherry picked from commit 39f6e99)
Bug: w5-20260625-1508-kimiclaw-confirm-openclaw- (primary) Finding: findings/20260625-1508-kimiclaw-confirm-openclaw-drivechain-frontends-bitwindow-lockwallet-send-toctou.md Severity: R3-T4 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> (cherry picked from commit 4ab561f)
Bug: w5-20260626-1707-kimiclaw-confirm-openclaw- (primary) Finding: findings/20260626-1707-kimiclaw-confirm-openclaw-drivechain-frontends-bitwindow-getnewaddress-locked-wallet.md Severity: R3-T4 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> (cherry picked from commit 0d72248)
…json overwrite while observably locked Bug: w5-20260627-1044-kimiclaw-confirm-glmclaw-d (primary) Finding: findings/20260627-1044-kimiclaw-confirm-glmclaw-drivechain-frontends-bitwindow-restorebackup-locked-wallet-swap.md Severity: R3-T4 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> (cherry picked from commit cd02f22)
…son + multisig + tx DB exfiltration while observably locked Bug: w5-20260627-1052-kimiclaw-confirm-glmclaw-d (primary) Finding: findings/20260627-1052-kimiclaw-confirm-glmclaw-drivechain-frontends-bitwindow-createbackup-locked-wallet-exfiltration.md Severity: R3-T4 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> (cherry picked from commit 550b409)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A set of 9 independent fixes to the BitWindow wallet & cheque API, stacked on one branch so they can be reviewed together and cherry-picked individually. Based on current
master; the branch builds and its tests pass at the tip (9 files changed, 652 insertions(+), 40 deletions(-)).Fixes (oldest first)
4af0a2431BitWindow marks zero-confirmation cheques as funded and exposes the bearer private key before any confirmation3dba42257BitWindowCreateSidechainDepositaccepts negativeint64 slotand wraps it touint32, forwarding0xffffffffasSidechainIdto the enforcer142a663e3BitWindow CreateCheque accepts zero expected amount and locks the record once funded47aaea5b3BitWindowcheques.GetNextIndexreuses HD indices after delete → deterministic address reuse and cross-cheque fund attribution59109e8e2BitWindowSweepChequecross-walletwalletIdskipsUpdateSwept, leaving owner cheque row withswept_txid = NULL2a673ddfdBitWindow LockWallet lets an in-flight send complete after locked2eaa85a74BitWindow GetNewAddress succeeds while wallet is locked91d1e766bBitWindowRestoreBackupmissingIsUnlocked()guard — wallet.json overwrite while observably lockedcd263494bBitWindowCreateBackupmissingIsUnlocked()guard — wallet.json + multisig + tx DB exfiltration while observably lockedEach commit is self-contained —
git cherry-pick <sha>works for any of them. Happy to split, reorder, or drop any. Finding reports for individual fixes available on request.