net: forget a peer that runs another network - #144
Open
octobocto wants to merge 1 commit into
Open
Conversation
octobocto
force-pushed
the
2026-09-01-forget-foreign-peer
branch
from
September 5, 2026 06:14
26f011b to
8e9fee2
Compare
octobocto
force-pushed
the
2026-09-01-forget-foreign-peer
branch
from
September 5, 2026 06:22
8e9fee2 to
71a089c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A peer that answers with another network's magic never becomes useful, but the node keeps it in
known_peersand dials it again on every start. A datadir made before the default moved to alphanet still holds the two signet seeds.The node now calls the existing
forget_peerwhen the magic is wrong, and only then. A timeout still keeps the peer.