Skip to content

update codeql workflow - #1872

Merged
shankars99 merged 4 commits into
mainfrom
patch/shell-script-lint
Dec 16, 2025
Merged

shankars99 merged 4 commits into
mainfrom
patch/shell-script-lint

Conversation

@shankars99

@shankars99 shankars99 commented Dec 10, 2025 •

Copy link
Copy Markdown
Collaborator

Added a new shell linter in #1864 which throws https://github.com/LayerZero-Labs/devtools/actions/runs/20084955914/job/57620524890#step:3:173

Fixes in this PR are:

  1. Fixed SC2068 (Double quote array expansions) in both packages/ua-devtools-solana/bin/test and packages/protocol-devtools-solana/bin/test by changing $@ to "$@".

  2. Fixed SC1090 (Can't follow non-constant source) in bin/env by adding # shellcheck source=/dev/null to explicitly ignore the warning for the dynamic source target. Also quoted the path "${1:-.env}" for better safety.

and remove codeql - rust (this did not run on original codeql runs and solana isn't regular rust so it doesn't really help)

Signed-off-by: shankar shankar@layerzerolabs.org

@github-actions

Copy link
Copy Markdown
Contributor

🚨 E2E Tests Failed

The E2E tests failed during CI. These tests validate real blockchain interactions and may fail due to:

This is non-blocking and does not prevent merging. Check the action logs above for detailed failure information.

@github-actions

Copy link
Copy Markdown
Contributor

🚨 E2E Tests Failed

The E2E tests failed during CI. These tests validate real blockchain interactions and may fail due to:

This is non-blocking and does not prevent merging. Check the action logs above for detailed failure information.

@shankars99 shankars99 changed the title lint: fix shell script errors update codeql workflow Dec 10, 2025
Signed-off-by: shankar <shankar@layerzerolabs.org>
Signed-off-by: shankar <shankar@layerzerolabs.org>
Signed-off-by: shankar <shankar@layerzerolabs.org>
@shankars99
shankars99 force-pushed the patch/shell-script-lint branch from ce9fc80 to 673f5a9 Compare December 10, 2025 23:08
@shankars99
shankars99 enabled auto-merge December 10, 2025 23:08
@github-actions

Copy link
Copy Markdown
Contributor

🚨 E2E Tests Failed

The E2E tests failed during CI. These tests validate real blockchain interactions and may fail due to:

This is non-blocking and does not prevent merging. Check the action logs above for detailed failure information.

@github-actions

Copy link
Copy Markdown
Contributor

🚨 E2E Tests Failed

The E2E tests failed during CI. These tests validate real blockchain interactions and may fail due to:

This is non-blocking and does not prevent merging. Check the action logs above for detailed failure information.

@shankars99
shankars99 disabled auto-merge December 11, 2025 21:03
@shankars99
shankars99 enabled auto-merge December 11, 2025 21:03
@shankars99
shankars99 disabled auto-merge December 16, 2025 00:21
@shankars99
shankars99 added this pull request to the merge queue Dec 16, 2025
Merged via the queue into main with commit c45bec8 Dec 16, 2025
21 checks passed
@shankars99
shankars99 deleted the patch/shell-script-lint branch December 16, 2025 00:42
@shankars99 shankars99 self-assigned this Dec 17, 2025
@shankars99 shankars99 added the ready to review in a state where CI passes and the PR is quite upto date with main and you need reviews label Dec 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to review in a state where CI passes and the PR is quite upto date with main and you need reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants