Skip to content

feat(web): another Environment's browser is named by the shell, not by its address - #55

Merged
immakermatty merged 2 commits into
mainfrom
dev6646/environment-name
Oct 12, 2026
Merged

immakermatty merged 2 commits into
mainfrom
dev6646/environment-name

Conversation

@immakermatty

Copy link
Copy Markdown

Status: ready for review. Merge after Lazurio/LazurioPlatform#339, which adds the element. The order is not critical: without the element the head falls back (below).

Why

On 2026-10-12, Matěj asked that an Environment be named the same everywhere, from one source: the switcher and the browser view's badge are the same thing. The panel's head over another Environment's view named it " · " from the view's address. That was a third copy of a rule the shell does not follow: an Environment is named by its own name and who it is for, never by its machine.

What changes

  • The head over another Environment's view is now the shell's <lazurio-environment environment="<id>" lang> (LazurioPlatform#339, F39 addendum of 2026-10-12).
    • It names that Environment as its switcher does: glyph, name and who line, from this page's shell state (the person's account merged in).
    • viewEnvironmentId gives the id: the view's host between browser. and .lazurio.io (vm-02.acme, jana).
  • Fallback: until the shell knows that Environment, and on a Platform without the element, the head says only "Prohlížeč jiného Environmentu" / "Another Environment's browser". The view's own bar right under it names the Environment precisely: it asks this page's shell, or uses its server's identity.
  • No name left elsewhere: the frame's title and the sign-in notice ("Přihlas se do prohlížeče tohoto Environmentu") no longer carry a name.
  • Removed: foreignEnvironmentLabel, foreignEnvironmentIcon and the GitHub picture. The fork has no naming rule of its own.
  • Runbook: "Záložka jiného Environmentu" is updated.

What does not change

  • The warning look (border, coloured head), the framing, the referrer policy, the sign-in fallback's timing and actions.
  • This Environment's own view head ("Environment browser").

Verification

  • vp test run src/lazurio (web): 72 passed. The foreign-view test now checks:
    • the element's environment (vm-02.acme) and lang;
    • the fallback text;
    • no old label and no picture;
    • the frame titles.
    • The id test covers an Organization's Environment, a personal one and more labels.
  • node --test scripts/lazurio-release-contract.test.mjs: 22 passed.
  • vp fmt --check: clean. Web typecheck: clean.
  • Browser check (root 0178) on the canary after the Platform release: another Environment's tab in T3's panel shows the same name as that Environment's switcher.

🤖 Generated with Claude Code

immakermatty and others added 2 commits October 12, 2026 13:08
…y its address

The panel's head over another Environment's view named it "<Org> · <machine>"
from the view's address, a third copy of a rule the shell does not follow.
The shell names an Environment by its own name and who it is for, never by
its machine. Matěj asked on 2026-10-12 that the same Environment be named the
same everywhere, from one source.

The head is now the shell's `<lazurio-environment environment="<id>" lang>`
(LazurioPlatform F39, addendum of 2026-10-12). It names that Environment as
its switcher does, from this page's shell state. The id is the view's host
between `browser.` and `.lazurio.io` (`viewEnvironmentId`).

Until the shell knows that Environment, and on a Platform without the element,
the head says only "Prohlížeč jiného Environmentu" ("Another Environment's
browser"). The view's own bar under it names the Environment precisely. The
frame's title and the sign-in notice no longer carry a name.

`foreignEnvironmentLabel`, `foreignEnvironmentIcon` and the GitHub picture
are removed.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…e fork runbook

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

@agentrozjedemeai agentrozjedemeai left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@immakermatty — APPROVED for exact head a20a6ef. The foreign-view header passes the validated view-host Environment ID to the Platform shell element; React 19 renders environment/lang/class as attributes, including the warning classes, and its light-DOM child remains the generic fallback before upgrade or on older Platforms. The warning border/header, iframe origin policy and sign-in timeout/actions remain intact; frame title/sign-in text no longer invent a name. Locally: web overlay 72/72, release contract 22/22, web typecheck and focused format check pass; diff --check clean. Dependency: merge after Lazurio/LazurioPlatform#339 for shell-provided identity; without it the generic header remains. This review does not merge or release.

@immakermatty
immakermatty merged commit b122de4 into main Oct 12, 2026
7 checks passed
@immakermatty

Copy link
Copy Markdown
Author

Merged (rebase) at b122de4 and released in 0.0.45-preview.20261012.2, on the canary. The local worktree was removed after verifying both commits are on main and the remote branch holds the same head.

@immakermatty
immakermatty deleted the dev6646/environment-name branch October 13, 2026 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants