Repository navigation
test(server): a neutral Environment label in the label override test - #59
Merged
Merged
Conversation
The test of the T3CODE_ENVIRONMENT_LABEL override used a real organization's name as its sample label. This repository is public, so the sample is now the neutral "Acme / Management", the form the fork runbook already uses. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
agentrozjedemeai
approved these changes
Oct 12, 2026
agentrozjedemeai
left a comment
agentrozjedemeai
left a comment
Collaborator
There was a problem hiding this comment.
@immakermatty Exact-head review of 9a416af: approved. The diff only replaces the real organization sample with the neutral Acme / Management in both the environment override input and expectation; the trimming assertion remains intact and the runbook uses the same neutral example. The current tree has no occurrence of the previous name; published history is deliberately not rewritten. git diff --check is clean. CI on this SHA passed, including ServerEnvironmentLabel.test.ts (9 tests). No unresolved review threads. No local package install/test was run in the isolated checkout; test evidence is from the exact-head CI run.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The test of the
T3CODE_ENVIRONMENT_LABELoverride inapps/server/src/environment/ServerEnvironmentLabel.test.tsused a real organization's name as its sample label. This repository is public.Fix
The sample label is now the neutral
Acme / Management, the form the fork runbook already uses. Input and expectation change together. Behaviour is unchanged.The name stays in the history of
main. Nothing here rewrites published history.Verification
vp test run src/environment/ServerEnvironmentLabel.test.ts(apps/server): 9 passed.git grepover the tree finds no other organization names.🤖 Generated with Claude Code (Claude Opus 5.5)