Add support for capturing Bayer RAW - #3
Conversation
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
There was a problem hiding this comment.
Pull request overview
This PR adds documentation for capturing Bayer RAW photos to the existing photo capture documentation. The documentation has been reorganized to consolidate RAW capture information (both Apple ProRAW and Bayer RAW) into a unified section with clearer guidance on availability and usage.
Key Changes:
- Added a new "RAW Photo" section explaining RAW capture configuration with availability details for Apple ProRAW and Bayer RAW
- Restructured documentation to consolidate previously separate Apple ProRAW section into the general RAW capture section
- Updated guidance on saving photos with clarifications for proxy photo handling and 24MP capture
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| > tip: | ||
| > You can use the convenience method ``PhotoCaptureConfiguration/configuredFor24MPPhotoCapture()`` to setup the configuration | ||
|
|
||
| ##### RAW Photo |
There was a problem hiding this comment.
Remove the trailing space after "RAW Photo". There is unnecessary whitespace at the end of this heading.
| ##### RAW Photo | |
| ##### RAW Photo |
| ```swift | ||
| let profile = CameraCaptureProfile(sessionPreset: .photo) { | ||
| PhotoCaptureService(options: .appleProRAW) | ||
| } | ||
| let configuration = PhotoCaptureConfiguration(dataFormat: .raw) | ||
| ``` |
There was a problem hiding this comment.
The code example shows using .appleProRAW option but sets the dataFormat to .raw, which would capture Bayer RAW instead of Apple ProRAW. This is inconsistent with the preceding text that says "If you want Apple ProRAW, also opt-in PhotoCaptureOptions/appleProRAW on the output." Either the code should use a data format that captures Apple ProRAW (the DataFormat enum doesn't seem to have an appleProRAW case based on the code, so this would just be .raw with the option enabled), or the example should be clarified to show Bayer RAW capture without the appleProRAW option.
| You should use ``CameraShutterButton`` in the first place. | ||
|
|
||
| If you want to use your custom controls, call ``Camera/takePhoto(configuration:dataRepresentationCustomizer:)`` to trigger a capture and receive a ``CapturedPhoto`` value: | ||
| You can also capture a photo programmatically via ``Camera/takePhoto(configuration:dataRepresentationCustomizer:)`` and receive a ``CapturedPhoto`` value: |
There was a problem hiding this comment.
The sentence structure is awkward. Consider rephrasing to: "You can also capture a photo programmatically by calling Camera/takePhoto(configuration:dataRepresentationCustomizer:) to receive a CapturedPhoto value:"
| You can also capture a photo programmatically via ``Camera/takePhoto(configuration:dataRepresentationCustomizer:)`` and receive a ``CapturedPhoto`` value: | |
| You can also capture a photo programmatically by calling ``Camera/takePhoto(configuration:dataRepresentationCustomizer:)`` to receive a ``CapturedPhoto`` value: |
No description provided.