Feature/ics rework/mime

[lucs7]

This pull request enhances the email attachment handling system by allowing MIME types to be specified for string attachments, ensuring correct content types are used when sending emails.

Depends on #1656

[Copilot]

Pull request overview

This PR extends LibreBooking’s email attachment pipeline so IEmailMessage string attachments can optionally provide an explicit MIME Content-Type, allowing reservation .ics attachments to be sent with text/calendar; ...; method=REQUEST instead of relying on filename-based detection. It also incorporates the attachment-leak fix from the dependent PR (#1656) by clearing PHPMailer attachments before each send.

Changes:

• Add optional $mimeType support to IEmailMessage::AddStringAttachment(...) and propagate it through EmailMessage + EmailService into PHPMailer’s addStringAttachment(...).
• Update reservation ICS generation to set an explicit calendar MIME type.
• Add PHPUnit coverage for EmailService attachment clearing and MIME passthrough.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
tests/lib/Email/EmailServiceTest.php	Adds unit tests for clearing attachments per send and passing MIME type into PHPMailer.
tests/fakes/FakeEmailMessage.php	Introduces a minimal IEmailMessage fake that supports string attachments + optional MIME type.
tests/fakes/TestReservationEmailMessage.php	Adds a reservation-email fake intended to expose ICS attachment generation for testing.
tests/fakes/namespace.php	Registers new fakes in the global test bootstrap.
lib/Email/IEmailMessage.php	Extends the interface to accept/return attachment MIME type.
lib/Email/EmailMessage.php	Stores and exposes the optional attachment MIME type.
lib/Email/EmailService.php	Clears attachments before each send and forwards MIME type to PHPMailer.
lib/Email/Messages/ReservationEmailMessage.php	Sets the ICS attachment MIME type to text/calendar; charset=UTF-8; method=REQUEST.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[lucs7]

Code review

Found 1 issue:

1. ReservationEmailMessage::PopulateIcsAttachment() hardcodes the ICS attachment's Content-Type as method=REQUEST for every reservation email, including cancellations and shares. ReservationDeletedEmail (a cancellation notice) and ReservationShareEmail (a plain share/export) don't override this method, so they'll also ship method=REQUEST in the attachment header. Per RFC 5546/iTip, a cancellation should use method=CANCEL and a share/export should use method=PUBLISH — with the wrong value, RFC 5546-aware clients (e.g. Gmail, Outlook) may render incorrect or missing Accept/Decline/Cancel scheduling UI for these emails.

librebooking/lib/Email/Messages/ReservationEmailMessage.php

Lines 220 to 227 in 1e62cc7

	$display = new CalendarExportDisplay();
	$icsContents = $display->Render([$icsView]);
	$this->AddStringAttachment(
	$icsContents,
	'reservation.ics',
	'text/calendar; charset=UTF-8; method=REQUEST'
	);
	}

🤖 Generated with Claude Code

_{- If this code review was useful, please react with 👍. Otherwise, react with 👎.}

[lucs7]

Code review is true but mimics the current behaviour of the ics implementation. actual correct method follows in the next PR