refactor: implement pagination - #1672
Open
JohnVillalovos wants to merge 1 commit into
Open
Conversation
JohnVillalovos
commented
Aug 28, 2026
JohnVillalovos
commented
Collaborator
- Replace null parameters with actual page number and size
- Use page->GetPageNumber() and page->GetPageSize() for pagination
- Improves performance by limiting results per request
- Replace null parameters with actual page number and size - Use page->GetPageNumber() and page->GetPageSize() for pagination - Improves performance by limiting results per request
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements consistent pagination across several schedule/user/resource/admin listing presenters by replacing null paging parameters with values from the page (GetPageNumber() / GetPageSize()), reducing unbounded queries and aligning with PageableDataStore’s paging behavior.
Changes:
- Passes explicit page number + page size into schedule list retrieval (viewer + admin).
- Passes explicit page size into user/group/resource/reservation/blackout list retrieval, enabling
LIMIT/OFFSETpaging instead of “all results”. - Minor array formatting adjustments for consistency/readability.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Presenters/ViewSchedulesPresenter.php | Uses page-driven paging when loading schedules for the schedule viewer. |
| Presenters/Admin/ManageUsersPresenter.php | Uses page size for user list paging; minor array formatting cleanup. |
| Presenters/Admin/ManageSchedulesPresenter.php | Uses page size for schedule list paging in admin view. |
| Presenters/Admin/ManageResourcesPresenter.php | Uses page size for resource list paging. |
| Presenters/Admin/ManageReservationsPresenter.php | Uses page size for reservation list paging; minor array formatting cleanup. |
| Presenters/Admin/ManageGroupsPresenter.php | Uses page size for group list paging. |
| Presenters/Admin/ManageBlackoutsPresenter.php | Uses page size for blackout list paging. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.