fix: group CSV import ignoring read-only permissions on update - #1692
Open
santifpinformatica wants to merge 1 commit into
Open
fix: group CSV import ignoring read-only permissions on update#1692santifpinformatica wants to merge 1 commit into
santifpinformatica wants to merge 1 commit into
Conversation
GroupImportCsvRow only defines permissionsRead, but the update branch of ManageGroupsPresenter::Import() checked the nonexistent property $row->permissionsView. That check always evaluated as empty, so read-only permissions from the CSV were silently skipped whenever an existing group was updated. Full-access permissions were unaffected, since that branch checked the correct property. Fixed the condition to check $row->permissionsRead instead. Fixes LibreBooking#1665
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GroupImportCsvRow only defines permissionsRead, but the update branch of ManageGroupsPresenter::Import() checked the nonexistent property $row->permissionsView. That check always evaluated as empty, so read-only permissions from the CSV were silently skipped whenever an existing group was updated. Full-access permissions were unaffected, since that branch checked the correct property.
Fixed the condition to check $row->permissionsRead instead.
Fixes #1665