Skip to content

feat: add graceful sandbox runner draining - #386

Merged
danny-avila merged 2 commits into
mainfrom
sync/main
Nov 17, 2026
Merged

danny-avila merged 2 commits into
mainfrom
sync/main

Conversation

@github-actions

Copy link
Copy Markdown
Contributor

Automated snapshot sync from the internal monorepo. Merging this PR releases the changes to main. Commit trailers reference the source commits.

Source: ClickHouse/ai@6b9c5591b8db5a5eedf11bd12ec10261de3b3077
@danny-avila

Copy link
Copy Markdown
Collaborator

@codex review

Please review the current PR head 3c95df1. Confirm that this exact commit is the reviewed commit and ignore findings that apply only to earlier heads.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. More of your lovely PRs please.

Reviewed commit: 3c95df145a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-17T00:02:45.091741Z 374fd1c Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@danny-avila

Copy link
Copy Markdown
Collaborator

@codex review

Please review the current PR head 3c95df1. Confirm that this exact commit is the reviewed commit and ignore findings that apply only to earlier heads.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 👍

Reviewed commit: 374fd1c5c2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@danny-avila danny-avila left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the 24-file public runner-drain snapshot at 374fd1c. Updating from public main retained the reviewed changed lines, current Codex review is clean, and the supported macOS check now passes. Merge remains gated on finishing the current image builds.

@danny-avila danny-avila changed the title fix(codeapi): run sync validation on supported macOS runner feat: add graceful sandbox runner draining Nov 17, 2026
@danny-avila
danny-avila merged commit 4ab2a22 into main Nov 17, 2026
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant