Skip to content

🗜️ fix: Preserve Supported PDF Filter Aliases - #406

Merged
danny-avila merged 2 commits into
mainfrom
danny-avila/pdf-filter-aliases
Nov 17, 2026
Merged

danny-avila merged 2 commits into
mainfrom
danny-avila/pdf-filter-aliases

Conversation

@danny-avila

@danny-avila danny-avila commented Nov 17, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

I restored extraction of PDFs using supported abbreviated stream filters after the pypdf 7 upgrade.

  • Normalize /Fl, /AHx, and /A85 to their full filter names after checking the existing allowlist and single-filter restriction.
  • Preserve filter parameters and route Flate streams through the bounded decompressor.
  • Generate the wrapped-table regression fixture during qualification alongside the adversarial PDFs.
  • Test canonical and abbreviated names in scalar and array form, plus abbreviated filters in nested form XObjects.
  • Reject oversized alias streams, unsupported filters, and filter chains through the extraction endpoint.

Follow-up to #405. The unmodified worker rejected all six scalar/array abbreviation cases with INVALID_DOCUMENT.

Change Type

  • Bug fix (non-breaking change which fixes an issue)

Testing

  • Pass formatting, strict TypeScript checks, and all 19 extraction unit tests.
  • Reproduce six real-worker failures before the change and pass all six afterward.
  • Pass the full local container suite, including 15 new successful filter cases, four new rejection cases, all existing malformed-document checks, and seccomp/Landlock isolation and restart checks.

Reproduce in packages/extraction: npm ci --ignore-scripts, npm run format:check, npm run typecheck, npm test, and npm run test:container.

All 25 GitHub checks passed on exact head 38ad141db823813d5d76b68fbd51b7ecacb50a52. Codex review is clean with no inline findings. Independent approval is required before merge.

Checklist

  • My code adheres to this project's style guidelines
  • I have performed a self-review of my own code
  • I have commented in any complex areas of my code
  • My changes do not introduce new warnings
  • I have written tests demonstrating that my changes are effective or that my feature works
  • Local unit tests pass with my changes

@danny-avila

Copy link
Copy Markdown
Collaborator Author

@codex review

Please review the current PR head 23fd44b. Confirm that this exact commit is the reviewed commit and ignore findings that apply only to earlier heads. Check the PDF single-filter boundary, preserved DecodeParms, and bounded decoding for page/form stream aliases.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-17T12:13:24.333492Z 38ad141 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. What shall we delve into next?

Reviewed commit: 23fd44b639

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@danny-avila

Copy link
Copy Markdown
Collaborator Author

@codex review

Please review the current PR head 38ad141. Confirm that this exact commit is the reviewed commit and ignore findings that apply only to earlier heads. This head also generates the wrapped-table fixture during container qualification instead of tracking the PDF binary. The full container suite passed with runtime fixture generation.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Bravo.

Reviewed commit: 38ad141db8

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@danny-avila
danny-avila merged commit b1ed867 into main Nov 17, 2026
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant