Repository navigation
🪪 fix: Fence Stale Quarantine Receipts on Workspace Reuse - #407
Conversation
|
@codex review Please review the current PR head 36e1d48. Confirm that this exact commit is the reviewed commit and ignore findings that apply only to earlier heads. Audit the receipt authority from admission through rejection, cleanup/quarantine, successor admission and completion, and reset. Check legacy-receipt and mixed-version behavior. |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Hooray! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Summary
I prevented late cleanup or quarantine receipts from a rejected assignment from changing a workspace after a successor is admitted.
Closes #404. Follow-up to #401 and #402.
Change Type
Testing
bun run build.tsc --noEmit -p tsconfig.jsondiagnostics exactly matchorigin/main; that command currently reports existing module/configuration and type errors, with no new diagnostics.git diff --check.Reproduce from
service:bun install --frozen-lockfile,bun test src/workspace-tools/requests.test.ts src/bridge/concurrent-store.test.ts, andbun run build. SetBRIDGE_TEST_REDIS_URLonly to a disposable Redis instance to run the workspace request cases against real Redis; these tests flush that database.Compatibility
The existing receipt format and endpoints are unchanged. A receipt becomes stale when ownership moves, so late reports receive the existing
ASSIGNMENT_FENCEDresponse; the worker treats that definite refusal as terminal. Legacy epoch-zero receipts are rejected once a new-version server admits a successor. Complete the API rollout to protect admissions handled by every replica; old replicas retain the previous admission behavior during a mixed-version rollout.All 24 GitHub checks passed on exact head
36e1d486ee15ea292593ae8a4c0111613ceec94d; Codex review is clean with no inline findings. Independent approval is required before merge.Checklist