chore: preview workflow split - #349
Open
vitormattos wants to merge 5 commits into
Open
Conversation
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective: Split the preview pipeline into two workflows so preview builds can run for fork-based pull requests without exposing the deploy token.
Motivation: Before this PR, previews were not generated for pull requests opened from forks because the deploy step required repository secrets.
With this change, the build runs in the PR context and the deploy runs separately in a trusted context, reducing secret exposure risk while enabling previews for fork PRs.
With this will be possible see the preview at the follow PR:
Important
In this PR transitioning from the previous preview generation method to the new one, the Preview Build runs and publishes the artifact as usual, but the preview-deploy does not trigger yet because workflows using
workflow_runare only activated when they already exist on themainbranch.