Conversation
This reverts commit ffbca02.
|
Few more exercises:
|
|
And the one I couldn't get proper images for yesterday!
|
Co-authored-by: IamDg <iamdg.dev@proton.me>
|
Hi, Thank you for you contribution! Unfortunately, in the next weeks I won't be able to continue development of the app and all the releated job (this includes PR reviewing). Don't worry, I'll review your PR after this period! |
IamDg
left a comment
There was a problem hiding this comment.
Hi,
Thank you for your contribution!
The exercises are 90% correct, so my comments focused on the remaing fixes/improvements I found! Then, the PR is ready to be merged. I can apply changes for myself if you want.
| { | ||
| "name": "Broad Jump", | ||
| "force": "push", | ||
| "level": "intermediate", | ||
| "mechanic": "compound", | ||
| "equipment": null, | ||
| "primaryMuscles": [ | ||
| "glutes", | ||
| "quadriceps" | ||
| ], | ||
| "secondaryMuscles": [ | ||
| "hamstrings", | ||
| "calves", | ||
| "abdominals" | ||
| ], | ||
| "instructions": [ | ||
| "Stand with your feet about shoulder-width apart.", | ||
| "Lower into a quarter squat while swinging your arms behind you.", | ||
| "Explosively swing your arms forward and extend your hips, knees, and ankles to jump as far forward as possible.", | ||
| "Land softly with your knees and hips bent to absorb the impact.", | ||
| "Maintain balance in an athletic position before resetting for the next repetition." | ||
| ], | ||
| "category": "plyometrics", | ||
| "images": [ | ||
| "Broad_Jump/0.webp", | ||
| "Broad_Jump/1.webp" | ||
| ], | ||
| "id": "Broad_Jump" | ||
| }, |
There was a problem hiding this comment.
I've checked the current exercises in the dataset and it looks like this exercise is almost identical to the existing Standing Long Jump:
"name": "Standing Long Jump",
"force": "push",
"level": "beginner",
"mechanic": "compound",
"equipment": "body only",
"primaryMuscles": [
"quadriceps"
],
"secondaryMuscles": [
"calves",
"glutes",
"hamstrings"
],
"instructions": [
"This drill is best done in sand or other soft landing surface. Ensure that you are able to measure distance. Stand in a partial squat stance with feet shoulder width apart.",
"Utilizing a big arm swing and a countermovement of the legs, jump forward as far as you can.",
"Attempt to land with your feet out in front you, reaching as far as possible with your legs.",
"Measure the distance from your landing point to the starting point and track results."
],
"category": "plyometrics",
"images": [
"Standing_Long_Jump/0.webp",
"Standing_Long_Jump/1.webp"
],
"id": "Standing_Long_Jump"Therefore, I'd recommend to remove it to avoid duplicates
| { | |
| "name": "Broad Jump", | |
| "force": "push", | |
| "level": "intermediate", | |
| "mechanic": "compound", | |
| "equipment": null, | |
| "primaryMuscles": [ | |
| "glutes", | |
| "quadriceps" | |
| ], | |
| "secondaryMuscles": [ | |
| "hamstrings", | |
| "calves", | |
| "abdominals" | |
| ], | |
| "instructions": [ | |
| "Stand with your feet about shoulder-width apart.", | |
| "Lower into a quarter squat while swinging your arms behind you.", | |
| "Explosively swing your arms forward and extend your hips, knees, and ankles to jump as far forward as possible.", | |
| "Land softly with your knees and hips bent to absorb the impact.", | |
| "Maintain balance in an athletic position before resetting for the next repetition." | |
| ], | |
| "category": "plyometrics", | |
| "images": [ | |
| "Broad_Jump/0.webp", | |
| "Broad_Jump/1.webp" | |
| ], | |
| "id": "Broad_Jump" | |
| }, |
| "force": "static", | ||
| "level": "beginner", | ||
| "mechanic": "compound", | ||
| "equipment": null, |
There was a problem hiding this comment.
| "equipment": null, | |
| "equipment": body only, |
| "force": "static", | ||
| "level": "intermediate", | ||
| "mechanic": "compound", | ||
| "equipment": "other", |
There was a problem hiding this comment.
| "equipment": "other", | |
| "equipment": body only, |
| "force": "push", | ||
| "level": "intermediate", | ||
| "mechanic": "compound", | ||
| "equipment": null, |
There was a problem hiding this comment.
| "equipment": null, | |
| "equipment": body only, |
| "force": "static", | ||
| "level": "intermediate", | ||
| "mechanic": "isolation", | ||
| "equipment": null, |
There was a problem hiding this comment.
| "equipment": null, | |
| "equipment": body only, |
| "force": "pull", | ||
| "level": "beginner", | ||
| "mechanic": "isolation", | ||
| "equipment": null, |
There was a problem hiding this comment.
| "equipment": null, | |
| "equipment": body only, |
| "name": "Hollow Hold", | ||
| "force": "static", | ||
| "level": "intermediate", | ||
| "mechanic": "isolation", |
There was a problem hiding this comment.
The hollow hold is a full-body, multi-segment anti-extension isometric hold (resisting spinal extension and hip extension). Change:
| "mechanic": "isolation", | |
| "mechanic": "compound", |
| "primaryMuscles": [ | ||
| "abdominals" | ||
| ], | ||
| "secondaryMuscles": [], |
There was a problem hiding this comment.
Holding straight legs elevated against gravity requires forceful isometric contraction of the hip flexors, particularly the rectus femoris. Add
| "secondaryMuscles": [], | |
| "secondaryMuscles": [ | |
| "quadriceps" | |
| ], |
| "secondaryMuscles": [ | ||
| "forearms", | ||
| "traps", | ||
| "shoulders", | ||
| "glutes" | ||
| ], |
There was a problem hiding this comment.
The contralateral quadratus lumborum (lower back) works intensely to prevent lateral flexion of the spine toward the weighted side.
| "secondaryMuscles": [ | |
| "forearms", | |
| "traps", | |
| "shoulders", | |
| "glutes" | |
| ], | |
| "secondaryMuscles": [ | |
| "forearms", | |
| "traps", | |
| "shoulders", | |
| "glutes", | |
| "lower back" | |
| ], |
| "Land softly on the balls of your feet and immediately rebound into the next jump while maintaining a consistent rhythm.", | ||
| "A common progression or alternative is Forward Pogos (Pogo Jumping Forward)" |
There was a problem hiding this comment.
Last instruction is an editorial commentary, not an actionable instruction, so it's better to remove it.
| "Land softly on the balls of your feet and immediately rebound into the next jump while maintaining a consistent rhythm.", | |
| "A common progression or alternative is Forward Pogos (Pogo Jumping Forward)" | |
| "Land softly on the balls of your feet and immediately rebound into the next jump while maintaining a consistent rhythm." |
Adding the Following exercises:
[x] The images are in .webp format with a white background.
[x] Corresponding folders have been created in
app/src/main/assets/with the correct id.[x] The
exercises.jsonis validated with thevalidate_exercises_json.py[x] The instructions are clear and detailed.
[x] The ids are unique and there are no duplicates.