Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ edition = "2024"
# (`toolchain: "1.98.1"`). Raise when the pin moves.
rust-version = "1.98.1"
license = "MIT OR Apache-2.0"
authors = ["Raul Montoya Cardenas <montoyaraul34@gmail.com>"]
authors = ["Raul Cardenas Montoya <montoyaraul34@gmail.com>"]

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P3: The stated rationale is to align the crates.io author display name with the GitHub profile, but the evidence points the other way: the GitHub profile (github.com/rmems) displays "Raul Montoya Cardenas", and the same ordering is used in this repo's CITATION.cff (family-names: Montoya Cardenas) and LICENSE-MIT (Copyright (c) 2026 Raul Montoya Cardenas), plus the LinkedIn handle raul-montoya-cardenas. Changing Cargo.toml to "Raul Cardenas Montoya" therefore appears to make crates.io less consistent with the profile the PR claims to match, and it creates a three-way metadata inconsistency inside the repo. Confirm the current GitHub display name before merging, and if the reorder is intentional, update CITATION.cff and LICENSE-MIT to the same ordering so the repo's author metadata stays consistent.

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At Cargo.toml, line 9:

<comment>The stated rationale is to align the crates.io author display name with the GitHub profile, but the evidence points the other way: the GitHub profile (github.com/rmems) displays "Raul Montoya Cardenas", and the same ordering is used in this repo's CITATION.cff (`family-names: Montoya Cardenas`) and LICENSE-MIT (`Copyright (c) 2026 Raul Montoya Cardenas`), plus the LinkedIn handle raul-montoya-cardenas. Changing Cargo.toml to "Raul Cardenas Montoya" therefore appears to make crates.io less consistent with the profile the PR claims to match, and it creates a three-way metadata inconsistency inside the repo. Confirm the current GitHub display name before merging, and if the reorder is intentional, update CITATION.cff and LICENSE-MIT to the same ordering so the repo's author metadata stays consistent.</comment>

<file context>
@@ -6,7 +6,7 @@ edition = "2024"
 rust-version = "1.98.1"
 license = "MIT OR Apache-2.0"
-authors = ["Raul Montoya Cardenas <montoyaraul34@gmail.com>"]
+authors = ["Raul Cardenas Montoya <montoyaraul34@gmail.com>"]
 description = "Pure-Rust implementation of the Neuromorphic Intermediate Representation (NIR) — the standard interchange format for spiking neural networks."
 repository = "https://github.com/Limen-Neural/nir-rs"
</file context>
Suggested change
authors = ["Raul Cardenas Montoya <montoyaraul34@gmail.com>"]
authors = ["Raul Montoya Cardenas <montoyaraul34@gmail.com>"]

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Intentional. GitHub GET /user for rmems currently returns display name Raul Cardenas Montoya (email montoyaraul34@gmail.com). This PR is scoped to Cargo.toml authors only; CITATION.cff / LICENSE-MIT stay as-is.

Cited by: Crates.io handler (Grok Bot).

description = "Pure-Rust implementation of the Neuromorphic Intermediate Representation (NIR) — the standard interchange format for spiking neural networks."
repository = "https://github.com/Limen-Neural/nir-rs"
homepage = "https://github.com/Limen-Neural/nir-rs"
Expand Down
Loading