Skip to content

chore(ci): retire Docker release artifact - #58

Merged
rmems merged 1 commit into
mainfrom
codex/linear-mention-lim-1378-chorerepo-retire-nir-rs-docker
Sep 18, 2026
Merged

rmems merged 1 commit into
mainfrom
codex/linear-mention-lim-1378-chorerepo-retire-nir-rs-docker

Conversation

@rmems

@rmems rmems commented Sep 18, 2026

Copy link
Copy Markdown
Member

User description

Motivation

  • Remove the root Docker release image and its publication workflow to reduce maintenance and avoid duplicating Cargo-based release verification.
  • Preserve full HDF5 interoperability validation in native CI across supported platforms and keep crates.io as the supported distribution path.

Description

  • Delete the root Dockerfile, .dockerignore, and .github/workflows/docker.yml to retire the published image and its publish steps.
  • Remove the Docker workflow badge and public pull/build instructions from README.md and update AGENTS.md to clarify that editor/dev containers are for development only and no runtime/release image is published.
  • Update Cargo.toml package exclude list and CHANGELOG.md to reflect the removal and document that native HDF5 CI remains.
  • Verify packaging excludes the removed Docker files so the crates.io artifact remains clean.

Testing

  • Ran cargo fmt --check and it succeeded.
  • Ran cargo test, cargo test --features serde, and cargo test --all-features, and all tests passed.
  • Ran cargo clippy --all-targets --all-features -- -D warnings and cargo clippy --all-targets --features hdf5,hdf5/static,hdf5/zlib -- -D warnings, and both returned clean results.
  • Built docs with cargo doc --no-deps --all-features and ran cargo package --list --locked --allow-dirty to confirm the package list does not include Dockerfile, .dockerignore, or docker.yml, and the checks passed.

Codex Task


CodeAnt-AI Description

Retire the published Docker release image and its distribution workflow

What Changed

  • Docker Hub and GHCR release images are no longer built or published
  • Removed the root Docker build files, Docker CI workflow, Docker documentation, and release-image references
  • Clarified that development containers remain available, but no runtime or release image is provided
  • Native HDF5 interoperability checks remain documented across supported platforms, and crates.io remains the distribution path

Impact

✅ No Docker release artifacts or registry publishing
✅ Clearer development-container expectations
✅ Native HDF5 validation remains supported

💡 Usage Guide

Checking Your Pull Request

Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.

Talking to CodeAnt AI

Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:

@codeant-ai ask: Your question here

This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.

Example

@codeant-ai ask: Can you suggest a safer alternative to storing this secret?

Preserve Org Learnings with CodeAnt

You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:

@codeant-ai: Your feedback here

This helps CodeAnt AI learn and adapt to your team's coding style and standards.

Example

@codeant-ai: Do not flag unused imports.

Retrigger review

Ask CodeAnt AI to review the PR again, by typing:

@codeant-ai: review

Check Your Repository Health

To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.


Summary by cubic

Retires the Docker release image and its publication workflow so crates.io remains the sole distribution path and Cargo-based release verification is no longer duplicated.

  • Deletes the root Dockerfile, .dockerignore, and .github/workflows/docker.yml.
  • Removes the Docker badge, pull/build instructions, and image references from README.md.
  • Updates AGENTS.md to clarify that editor/dev containers are for development only.
  • Cleans the Cargo.toml package exclude list and records the removal in CHANGELOG.md.
  • Keeps HDF5 interoperability validation in native CI across Linux, macOS, and Windows.

Written for commit 06faa40. Summary will update on new commits.

Review in cubic

@codeant-ai

codeant-ai Bot commented Sep 18, 2026

Copy link
Copy Markdown

🤖 CodeAnt AI — Review Status

Status Commit Started (UTC) Finished (UTC)
✅ Reviewed your PR 06faa40 Sep 18, 2026 · 05:00 05:01

@codeant-ai

codeant-ai Bot commented Sep 18, 2026

Copy link
Copy Markdown

Thanks for using CodeAnt! 🎉

We're free for open-source projects. if you're enjoying it, help us grow by sharing.

Share on X ·
Reddit ·
LinkedIn

@linear-code

linear-code Bot commented Sep 18, 2026

Copy link
Copy Markdown

LIM-1378

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 18, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-18T05:03:38.559665Z 06faa40 PR opened
🔒 Security Review Completed 2026-09-18T05:03:05.672095Z 06faa40 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@codeant-ai codeant-ai Bot added the size:S label Sep 18, 2026
@coderabbitai

coderabbitai Bot commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Essentials

Run ID: 8db3fada-705a-459e-9a66-79a1c5c4f517

📥 Commits

Reviewing files that changed from the base of the PR and between 2d1500d and 06faa40.

📒 Files selected for processing (7)
  • .dockerignore
  • .github/workflows/docker.yml
  • AGENTS.md
  • CHANGELOG.md
  • Cargo.toml
  • Dockerfile
  • README.md
💤 Files with no reviewable changes (4)
  • .dockerignore
  • .github/workflows/docker.yml
  • Dockerfile
  • Cargo.toml

Included review availability: 0 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 1 review per hour.


📝 Summary

Summary by CodeRabbit

  • Removed

    • Removed the Dockerfile and automated Docker build, validation, and image publishing workflow.
    • Docker images are no longer published to Docker Hub or GitHub Container Registry.
    • Removed Docker status badges and usage documentation from the README.
  • Documentation

    • Clarified that distribution continues through crates.io, while editor-specific development containers remain available.
    • Documented expanded development-container support, including Rust 1.98.1 and HDF5 development libraries.
    • Added changelog entries covering native HDF5 interoperability validation across Linux, macOS, and Windows.

Walkthrough

The project removes its Dockerfile, Docker workflow, and Docker context exclusions. Package metadata and documentation now describe crates.io distribution and editor-specific development containers without published runtime or release images.

Changes

Docker distribution removal

Layer / File(s) Summary
Remove Docker build and publishing infrastructure
.dockerignore, Dockerfile, .github/workflows/docker.yml
Removes Docker build configuration, runtime image creation, pull-request checks, registry publishing, tag validation, and runtime smoke tests.
Align package and development configuration
Cargo.toml, AGENTS.md
Removes deleted Docker files from package exclusions and documents editor-specific development containers without published runtime or release images.
Update project documentation
README.md, CHANGELOG.md
Removes Docker badges, status references, usage instructions, and public image documentation. Records the retired publishing infrastructure and retained crates.io distribution.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Suggested labels: GItHub Actions, documentation

Merge Risk: ⚪ Minimal · up to 06faa

The retired Docker release path is removed while crates.io packaging and editor development containers remain supported.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: retiring the Docker release artifact and publication workflow.
Description check ✅ Passed The description directly explains the Docker artifact removal, documentation updates, packaging changes, retained native HDF5 validation, and completed testing.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
✨ Simplify code
  • Commit to this branch
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@deepsource-io

deepsource-io Bot commented Sep 18, 2026

Copy link
Copy Markdown

DeepSource Code Review

We reviewed changes in 2d1500d...06faa40 on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

PR Report Card

Overall Grade   Security  

Reliability  

Complexity  

Hygiene  

Code Review Summary

Analyzer Status Updated (UTC) Details
Rust Sep 18, 2026 5:00a.m. Review ↗
Secrets Sep 18, 2026 5:00a.m. Review ↗

Important

AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.

@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@amazon-q-developer amazon-q-developer Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR successfully retires the Docker release artifacts while preserving HDF5 validation in native CI and maintaining development containers for local development. The changes are well-documented and consistent:

  • Documentation correctly updated across AGENTS.md, CHANGELOG.md, and README.md to reflect that no runtime/release image is published
  • Cargo.toml exclude list properly cleaned up to remove Docker-related files
  • Changes align with the PR's stated goal of reducing maintenance burden while keeping crates.io as the primary distribution path

All modifications are documentation and configuration only with no logic changes. The PR is ready to merge.


You can now have the agent implement changes and create commits directly on your pull request's source branch. Simply comment with /q followed by your request in natural language to ask the agent to make changes.

@codecov

codecov Bot commented Sep 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 06faa40ea5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .dockerignore
@@ -1,24 +0,0 @@
# Keep Docker context small and free of secrets / build junk.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Keep an ignore file for the remaining container builds

Deleting this file also affects the retained development containers: .cursor/environment.json:3-5 and .devcontainer/devcontainer.json:3-5 both build .cursor/Dockerfile with the repository root as their context. On Docker clients/builders that upload the full context, starting either environment will now send .git, target, and ignored .env* files to the daemon or cloud builder, whereas this file previously excluded them; retain a root .dockerignore (or an equivalent Dockerfile-specific ignore file) even though the release image is gone. Docker documents that files matching .dockerignore are removed before the build context is sent.

AGENTS.md reference: AGENTS.md:L113-L121

Useful? React with 👍 / 👎.

@rmems
rmems merged commit b4dc783 into main Sep 18, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant