Repository navigation
rules: the index marks the last law at the bottom and a clicked law at once - #29
Merged
Merged
Conversation
|
review: 6b95fea
|
|
review: e128ea0
|
|
review: ee43a34
|
|
review: b9c1c92
|
|
review: 6de5c42
|
|
review: e7a111a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes LTET-29
On the Rules page the index never marked the photo credits: the last section is too short to scroll to the top of the window, so the first law in view stayed Honours, even after clicking Photo credits.
At the bottom of the page the index now marks the last law, worked out on scroll one frame at a time. Everywhere else it marks the first law in view, as before. A page too short to scroll keeps the old behaviour.
Tested: unit tests for the bottom of the page, scrolling back up and a short page. In a real browser on the live Rules page with this script, Photo credits is marked at the bottom and after clicking it (Honours before).