feat(match2): add dev environment support for br - #7996
Open
ElectricalBoy wants to merge 4 commits into
Open
Conversation
hjpalpha
approved these changes
Aug 21, 2026
Member
|
We have this for hte main page match ticker too. Is it feasible to implement a common usage that can be easily exnended in the future to other components if the need arises? |
Collaborator
Probably not, for the matchticker (or rather, filterbutton template expansion one can supply anything that fits into |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Match2 BR/FFA did not support directly applying dev environment arguments to game tabs as they were loaded via javascript due to performance reasons.
This PR exports the dev flag to the generated matchgroup display html code, allowing it to be picked up by javascript.
How did you test this change?
dev in pubg + dev proxy