fix: fix file suffix on eva - #8009
Open
Rathoz wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the EVA wiki MatchSummary module’s type annotation to reflect that CustomMatchSummary.createGame always returns a renderable widget (non-optional), aligning the LuaDoc with the function’s actual behavior and the base interface expectations.
Changes:
- Change
CustomMatchSummary.createGameLuaDoc return type fromRenderable?toRenderable.
Suppressed comments (1)
lua/wikis/eva/MatchSummary.lua:25
- The PR title suggests a functional change ("fix file suffix on eva"), but the diff only changes the LuaDoc return annotation for
createGamefrom optional to non-optional. Please update the PR title/summary (and testing notes) to match the actual change, or include the intended suffix-related fix if it is missing.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
steve020607
approved these changes
Aug 24, 2026
hjpalpha
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
How did you test this change?