Skip to content

Bind fstat$INODE64 on macOS x64 #855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
krejko wants to merge 1 commit into
base: canary
Choose a base branch
from
+18 −1
Open

Bind fstat$INODE64 on macOS x64 #855

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion listenarr.infrastructure/FileSystem/PinnedDirectoryCreation.NativeInterop.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -321,11 +321,28 @@ private static extern int FcntlGetPath(
int command,
IntPtr buffer);

// macOS exposes two incompatible fstat ABIs. On x86_64 the bare "fstat" symbol is the
// pre-10.5 variant whose struct predates the 64-bit inode layout, so reading it as
// MacStatInformation yields garbage - st_mode lands on the wrong offset and every regular
// file is misreported (observed: type 0x2000, a character device). C code never hits this
// because <sys/stat.h> redirects fstat to fstat$INODE64; a raw P/Invoke does not.
// On arm64 there is no $INODE64 suffix - the bare symbol is already the modern ABI, and
// binding "fstat$INODE64" there fails with EntryPointNotFoundException.
[DllImport("libc", EntryPoint = "fstat$INODE64", SetLastError = true)]
private static extern int FStatMacInode64(
int fileDescriptor,
out MacStatInformation information);

[DllImport("libc", EntryPoint = "fstat", SetLastError = true)]
private static extern int FStatMac(
private static extern int FStatMacNative(
int fileDescriptor,
out MacStatInformation information);

private static int FStatMac(int fileDescriptor, out MacStatInformation information) =>
RuntimeInformation.ProcessArchitecture == Architecture.X64
? FStatMacInode64(fileDescriptor, out information)
: FStatMacNative(fileDescriptor, out information);

[DllImport("libc", EntryPoint = "fsync", SetLastError = true)]
private static extern int FSync(int fileDescriptor);

Expand Down