fix(imports): support weak storage moves - #864
Draft
therobbiedavis wants to merge 3 commits into
Draft
Conversation
- copy and retain sources when durable identity is unavailable - journal compatibility publications and recover registration state - disclose effective move policy across API and UI
- Keep identity-state tests independent of Linux mount probing - Preserve dedicated coverage for storage access capability
- Avoid re-reading a nullable journal property inside the EF query - Make committed-publication ownership checks statically non-null
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Allows imports from filesystems that cannot expose durable file or directory generation identity. A requested move now degrades to a verified copy that explicitly retains the source, instead of blocking the import, while durable-storage moves keep their existing source-retirement contract.
Fixes #852
Related to #827
Changes
Added
CopyAndRetainSourceand can be disabled.Changed
remove_and_deleteto non-destructive client removal when any imported source was retained.Fixed
Testing
dotnet build listenarr.slnx --no-restoredotnet test listenarr.slnx --no-build --no-restore— 2,952 passed, 202 skippedValidateScopesandValidateOnBuilddotnet ef migrations has-pending-model-changes ... --no-build— no pending model changesdotnet format listenarr.slnx --no-restore --verify-no-changes --verbosity minimalnpm run test:unit -- --run— 89 files, 597 tests passednpm run build,npm run lint:check, andnpm run format:checkNotes
Moveis therefore successful asCopywithSourceDisposition=Retained; this is surfaced before import in the UI and after import in API/job history.