Skip to content

chore(linux/nvenc): document libavcodec HEVC behavior - #5691

Merged
ReenigneArcher merged 1 commit into
LizardByte:masterfrom
bitness:fix/linux-nvenc-hevc-yuv444
Oct 1, 2026
Merged

ReenigneArcher merged 1 commit into
LizardByte:masterfrom
bitness:fix/linux-nvenc-hevc-yuv444

Conversation

@bitness

@bitness bitness commented Sep 11, 2026 •

Copy link
Copy Markdown
Contributor

Description

This change documents that libavcodec automatically selects the HEVC rext profile when setting up the Linux NVENC encoder for YUV 4:4:4 content.

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Unit tests have been added or updated for any new or modified functionality

AI Usage

See our AI usage policy.

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

@ReenigneArcher ReenigneArcher left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The proposed profile override appears unable to change the NVENC configuration on the supported FFmpeg path. I left the details inline.

Comment thread src/video.cpp Outdated
@bitness
bitness force-pushed the fix/linux-nvenc-hevc-yuv444 branch 2 times, most recently from 1fedf79 to 4a860c1 Compare September 30, 2026 18:33
@ReenigneArcher ReenigneArcher changed the title fix(linux/nvenc): select HEVC RExt profile for YUV 4:4:4 encoding chore(linux/nvenc): document libavcodec HEVC behavior Oct 1, 2026
This adds a comment documenting that libavcodec automatically uses the
rext profile when content is YUV444.
@ReenigneArcher
ReenigneArcher force-pushed the fix/linux-nvenc-hevc-yuv444 branch from 4a860c1 to 0656e91 Compare October 1, 2026 00:52
@sonarqubecloud

sonarqubecloud Bot commented Oct 1, 2026

Copy link
Copy Markdown

@codecov

codecov Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

Bundle Report

Bundle size has no change ✅

@codecov

codecov Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 39.70%. Comparing base (03fb771) to head (0656e91).
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5691   +/-   ##
=======================================
  Coverage   39.69%   39.70%           
=======================================
  Files         123      123           
  Lines       28825    28825           
  Branches    12534    12534           
=======================================
+ Hits        11443    11444    +1     
+ Misses      14557    14518   -39     
- Partials     2825     2863   +38     
Flag Coverage Δ
Alpine-aarch64 24.27% <ø> (-0.01%) ⬇️
Alpine-x86_64 24.39% <ø> (ø)
Archlinux 22.47% <ø> (+<0.01%) ⬆️
FreeBSD-amd64 24.51% <ø> (-0.02%) ⬇️
Homebrew-macos-15 40.14% <ø> (ø)
Homebrew-macos-26 40.44% <ø> (ø)
Homebrew-ubuntu-24.04 26.09% <ø> (ø)
Linux-AppImage-aarch64 27.27% <ø> (ø)
Linux-AppImage-x86_64 27.45% <ø> (ø)
PowerShell 100.00% <ø> (ø)
Web-UI 55.69% <ø> (ø)
Windows-AMD64 31.90% <ø> (ø)
Windows-ARM64 26.82% <ø> (-0.01%) ⬇️
macOS-arm64 33.18% <ø> (ø)
macOS-x86_64 33.77% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/video.cpp 54.62% <ø> (ø)

... and 44 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03fb771...0656e91. Read the comment docs.

@github-actions

github-actions Bot commented Oct 1, 2026

Copy link
Copy Markdown
Last Updated 2026-10-01 02:46:53 UTC
Source Run CI Run #5933
Commit 0656e91d257bb9a80e9ada24a0da02803af51636

Screenshot Comparison

PR #5691 screenshots vs screenshots baseline.

Matrix: AppImage-aarch64

Image Baseline PR
sunshine_tray_initial.png
sunshine_tray_menu.png
sunshine_tray_pairing_request.png
sunshine_tray_paused.png
sunshine_tray_stopped.png
sunshine_tray_streaming.png
sunshine_tray_tooltip.png

Matrix: AppImage-x86_64

Image Baseline PR
sunshine_tray_initial.png
sunshine_tray_menu.png
sunshine_tray_pairing_request.png
sunshine_tray_paused.png
sunshine_tray_stopped.png
sunshine_tray_streaming.png
sunshine_tray_tooltip.png

Matrix: Windows-AMD64

Image Baseline PR
sunshine_tray_initial.png
sunshine_tray_menu.png
sunshine_tray_pairing_request.png
sunshine_tray_paused.png
sunshine_tray_stopped.png
sunshine_tray_streaming.png
sunshine_tray_tooltip.png

Matrix: Windows-ARM64

Image Baseline PR
sunshine_tray_initial.png
sunshine_tray_menu.png
sunshine_tray_pairing_request.png
sunshine_tray_paused.png
sunshine_tray_stopped.png
sunshine_tray_streaming.png
sunshine_tray_tooltip.png

Matrix: macOS-arm64

Image Baseline PR
sunshine_tray_initial.png
sunshine_tray_menu.png
sunshine_tray_pairing_request.png
sunshine_tray_paused.png
sunshine_tray_stopped.png
sunshine_tray_streaming.png
sunshine_tray_tooltip.png

Matrix: macOS-x86_64

Image Baseline PR
sunshine_tray_initial.png
sunshine_tray_menu.png
sunshine_tray_pairing_request.png
sunshine_tray_paused.png
sunshine_tray_stopped.png
sunshine_tray_streaming.png
sunshine_tray_tooltip.png

@ReenigneArcher
ReenigneArcher merged commit dfa9e88 into LizardByte:master Oct 1, 2026
78 of 84 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants