Skip to content

feat(input): add Steam Controller (2nd generation) - #5773

Draft
ReenigneArcher wants to merge 2 commits into
masterfrom
feat/libvirtualhid-steam-controller
Draft

ReenigneArcher wants to merge 2 commits into
masterfrom
feat/libvirtualhid-steam-controller

Conversation

@ReenigneArcher

@ReenigneArcher ReenigneArcher commented Sep 21, 2026 •

Copy link
Copy Markdown
Member

Description

Adds Steam Controller (second gen) support.

TODO:

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Unit tests have been added or updated for any new or modified functionality

AI Usage

See our AI usage policy.

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

@codecov

codecov Bot commented Sep 21, 2026 •

Copy link
Copy Markdown

Bundle Report

Changes will increase total bundle size by 1.8kB (0.05%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sunshine-esm 979.0kB 1.8kB (0.18%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: sunshine-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index-*.js 152 bytes 396.09kB 0.04%
assets/Config-*.js 111 bytes 86.32kB 0.13%
images/logo-*.svg 27 bytes 2.17kB 1.26%
images/logo-*.svg (New) 1.51kB 1.51kB 100.0% 🚀

@codecov

codecov Bot commented Sep 21, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 91.60000% with 21 lines in your changes missing coverage. Please review.
✅ Project coverage is 39.72%. Comparing base (8fc4097) to head (dfe78bf).
⚠️ Report is 15 commits behind head on master.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/stream.cpp 4.54% 20 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5773      +/-   ##
==========================================
+ Coverage   39.30%   39.72%   +0.41%     
==========================================
  Files         120      120              
  Lines       27809    28008     +199     
  Branches    12165    12237      +72     
==========================================
+ Hits        10931    11125     +194     
+ Misses      14600    13861     -739     
- Partials     2278     3022     +744     
Flag Coverage Δ
Alpine-aarch64 24.18% <70.61%> (+0.49%) ⬆️
Alpine-x86_64 24.31% <71.42%> (+0.50%) ⬆️
Archlinux 22.25% <69.61%> (+0.42%) ⬆️
FreeBSD-amd64 24.70% <78.76%> (+0.67%) ⬆️
Homebrew-macos-15 39.80% <82.87%> (+0.67%) ⬆️
Homebrew-macos-26 40.10% <82.87%> (+0.66%) ⬆️
Homebrew-ubuntu-24.04 25.85% <72.44%> (+0.51%) ⬆️
Linux-AppImage-aarch64 27.00% <71.64%> (+0.47%) ⬆️
Linux-AppImage-x86_64 27.19% <72.44%> (+0.49%) ⬆️
PowerShell 100.00% <ø> (ø)
Web-UI 66.34% <100.00%> (+0.02%) ⬆️
Windows-AMD64 31.33% <75.69%> (+0.42%) ⬆️
Windows-ARM64 26.50% <77.57%> (+0.55%) ⬆️
macOS-arm64 33.12% <78.76%> (+0.82%) ⬆️
macOS-x86_64 33.71% <78.76%> (+0.82%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/input.cpp 58.17% <100.00%> (+1.65%) ⬆️
src/input.h 50.00% <ø> (ø)
src/platform/common.h 62.85% <100.00%> (+1.66%) ⬆️
src/platform/virtualhid_input.cpp 98.17% <100.00%> (+0.49%) ⬆️
src/system_tray.cpp 80.39% <ø> (ø)
...c_assets/common/assets/web/configs/tabs/Inputs.vue 68.10% <100.00%> (+0.27%) ⬆️
...ets/common/assets/web/public/assets/locale/en.json 100.00% <ø> (ø)
src/stream.cpp 22.37% <4.54%> (-0.38%) ⬇️

... and 26 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8fc4097...dfe78bf. Read the comment docs.

@github-actions

github-actions Bot commented Sep 21, 2026 •

Copy link
Copy Markdown
Last Updated 2026-09-28 14:31:24 UTC
Source Run CI Run #5838
Commit dfe78bf4f7687f6d6a3b3bfdd0560f28aaf90449

Screenshot Comparison

PR #5773 screenshots vs screenshots baseline.

Matrix: AppImage-aarch64

Image Baseline PR
sunshine_tray_initial.png
sunshine_tray_menu.png
sunshine_tray_pairing_request.png
sunshine_tray_paused.png
sunshine_tray_stopped.png
sunshine_tray_streaming.png
sunshine_tray_tooltip.png

Matrix: AppImage-x86_64

Image Baseline PR
sunshine_tray_initial.png
sunshine_tray_menu.png
sunshine_tray_pairing_request.png
sunshine_tray_paused.png
sunshine_tray_stopped.png
sunshine_tray_streaming.png
sunshine_tray_tooltip.png

Matrix: Windows-AMD64

Image Baseline PR
sunshine_tray_initial.png
sunshine_tray_menu.png
sunshine_tray_pairing_request.png
sunshine_tray_paused.png
sunshine_tray_stopped.png
sunshine_tray_streaming.png
sunshine_tray_tooltip.png

Matrix: Windows-ARM64

Image Baseline PR
sunshine_tray_initial.png
sunshine_tray_menu.png
sunshine_tray_pairing_request.png
sunshine_tray_paused.png
sunshine_tray_stopped.png
sunshine_tray_streaming.png
sunshine_tray_tooltip.png

Matrix: macOS-arm64

Image Baseline PR
sunshine_tray_initial.png
sunshine_tray_menu.png
sunshine_tray_pairing_request.png
sunshine_tray_paused.png
sunshine_tray_stopped.png
sunshine_tray_streaming.png
sunshine_tray_tooltip.png

Matrix: macOS-x86_64

Image Baseline PR
sunshine_tray_initial.png
sunshine_tray_menu.png
sunshine_tray_pairing_request.png
sunshine_tray_paused.png
sunshine_tray_stopped.png
sunshine_tray_streaming.png
sunshine_tray_tooltip.png

@ReenigneArcher
ReenigneArcher force-pushed the feat/libvirtualhid-steam-controller branch 2 times, most recently from a4fce24 to 5d760b3 Compare September 21, 2026 21:53
@ReenigneArcher ReenigneArcher changed the title feat: add 2026 Steam Controller support feat: add Steam Controller (2nd generation) support Sep 28, 2026
@ReenigneArcher
ReenigneArcher force-pushed the feat/libvirtualhid-steam-controller branch from 5d760b3 to 9ca55e0 Compare September 28, 2026 02:11
@ReenigneArcher ReenigneArcher changed the title feat: add Steam Controller (2nd generation) support feat(input): add Steam Controller (2nd generation) Sep 28, 2026
@ReenigneArcher
ReenigneArcher force-pushed the feat/libvirtualhid-steam-controller branch from 9ca55e0 to 8c45098 Compare September 28, 2026 02:20
@sonarqubecloud

Copy link
Copy Markdown

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant