feat(linux/pipewire): add pts passthrough whitelist, cleanups - #5791
Merged
ReenigneArcher merged 7 commits intoSep 25, 2026
Merged
Conversation
psyke83
force-pushed
the
pipewire_pts_whitelist
branch
2 times, most recently
from
September 24, 2026 23:53
fa7825f to
0b8f882
Compare
psyke83
marked this pull request as ready for review
September 25, 2026 00:24
ReenigneArcher
left a comment
ReenigneArcher
left a comment
Member
There was a problem hiding this comment.
doxygen errors:
/home/docs/checkouts/readthedocs.org/user_builds/sunshinestream/checkouts/5791/src/platform/linux/pipewire.cpp:699: error: Member negotiate_variable_rate (variable) of class pipewire::pipewire_t is not documented.
/home/docs/checkouts/readthedocs.org/user_builds/sunshinestream/checkouts/5791/src/platform/linux/pipewire.cpp:698: error: Member prefer_pipewire_pts (variable) of class pipewire::pipewire_t is not documented.
/home/docs/checkouts/readthedocs.org/user_builds/sunshinestream/checkouts/5791/src/platform/linux/pipewire.cpp:434: error: parameters of member pipewire::pipewire_t::get_running_compositor_version are not documented
/home/docs/checkouts/readthedocs.org/user_builds/sunshinestream/checkouts/5791/src/platform/linux/pipewire.cpp:540: error: parameters of member pipewire::pipewire_t::use_pipewire_pts are not documented
/home/docs/checkouts/readthedocs.org/user_builds/sunshinestream/checkouts/5791/src/platform/linux/pipewire.cpp:571: error: parameters of member pipewire::pipewire_t::use_variable_rate are not documented
/home/docs/checkouts/readthedocs.org/user_builds/sunshinestream/checkouts/5791/src/platform/linux/pipewire.cpp:410: error: Member type (variable) of struct pipewire::pipewire_t::compositor_version_t is not documented.
/home/docs/checkouts/readthedocs.org/user_builds/sunshinestream/checkouts/5791/src/platform/linux/pipewire.cpp:411: error: Member version (variable) of struct pipewire::pipewire_t::compositor_version_t is not documented.
Allow passthrough of more accurate pts metadata for specific compositor versions that are known to generate valid timestamps. * Add GNOME Shell (Mutter) detection function. * Reuse existing KWin detection for pts whitelist. * Guard against stale Pipewire pts metadata. * Initialize variables in init() once to avoid first-run stalls in fill_img_metadata() when determining pts source. * Refactor logic to determine if variable framerate should be negotiated into separate function.
ReenigneArcher
force-pushed
the
pipewire_pts_whitelist
branch
from
September 25, 2026 19:16
e239f72 to
1520bee
Compare
Bundle ReportBundle size has no change ✅ |
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5791 +/- ##
==========================================
- Coverage 38.43% 38.36% -0.07%
==========================================
Files 113 113
Lines 26056 26099 +43
Branches 11538 11558 +20
==========================================
Hits 10014 10014
+ Misses 15170 13940 -1230
- Partials 872 2145 +1273
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 45 files with indirect coverage changes Continue to review full report in Codecov by Harness.
|
Screenshot ComparisonPR #5791 screenshots vs Matrix:
|
| Image | Baseline | PR |
|---|---|---|
sunshine_tray_initial.png |
 |
 |
sunshine_tray_menu.png |
 |
 |
sunshine_tray_pairing_request.png |
 |
 |
sunshine_tray_paused.png |
 |
 |
sunshine_tray_stopped.png |
 |
 |
sunshine_tray_streaming.png |
 |
 |
sunshine_tray_tooltip.png |
 |
 |
Matrix: AppImage-x86_64
| Image | Baseline | PR |
|---|---|---|
sunshine_tray_initial.png |
 |
 |
sunshine_tray_menu.png |
 |
 |
sunshine_tray_pairing_request.png |
 |
 |
sunshine_tray_paused.png |
 |
 |
sunshine_tray_stopped.png |
 |
 |
sunshine_tray_streaming.png |
 |
 |
sunshine_tray_tooltip.png |
 |
 |
Matrix: Windows-AMD64
| Image | Baseline | PR |
|---|---|---|
sunshine_tray_initial.png |
 |
 |
sunshine_tray_menu.png |
 |
 |
sunshine_tray_pairing_request.png |
 |
 |
sunshine_tray_paused.png |
 |
 |
sunshine_tray_stopped.png |
 |
 |
sunshine_tray_streaming.png |
 |
 |
sunshine_tray_tooltip.png |
 |
 |
Matrix: Windows-ARM64
| Image | Baseline | PR |
|---|---|---|
sunshine_tray_initial.png |
 |
 |
sunshine_tray_menu.png |
 |
 |
sunshine_tray_pairing_request.png |
 |
 |
sunshine_tray_paused.png |
 |
 |
sunshine_tray_stopped.png |
 |
 |
sunshine_tray_streaming.png |
 |
 |
sunshine_tray_tooltip.png |
 |
 |
Matrix: macOS-arm64
| Image | Baseline | PR |
|---|---|---|
sunshine_tray_initial.png |
 |
 |
sunshine_tray_menu.png |
 |
 |
sunshine_tray_pairing_request.png |
 |
 |
sunshine_tray_paused.png |
 |
 |
sunshine_tray_stopped.png |
 |
 |
sunshine_tray_streaming.png |
 |
 |
sunshine_tray_tooltip.png |
 |
 |
Matrix: macOS-x86_64
| Image | Baseline | PR |
|---|---|---|
sunshine_tray_initial.png |
 |
 |
sunshine_tray_menu.png |
 |
 |
sunshine_tray_pairing_request.png |
 |
 |
sunshine_tray_paused.png |
 |
 |
sunshine_tray_stopped.png |
 |
 |
sunshine_tray_streaming.png |
 |
 |
sunshine_tray_tooltip.png |
 |
 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Allow passthrough of more accurate pts metadata for specific compositor versions that are known to generate valid timestamps.
Screenshot
Issues Fixed or Closed
Roadmap Issues
Type of Change
Checklist
AI Usage
See our AI usage policy.