Skip to content

fix(input): honor extended keyboard modifier - #5821

Merged
ReenigneArcher merged 1 commit into
masterfrom
feat/MODIFIER_EXTENDED
Sep 29, 2026
Merged

ReenigneArcher merged 1 commit into
masterfrom
feat/MODIFIER_EXTENDED

Conversation

@ReenigneArcher

Copy link
Copy Markdown
Member

Description

See #5815 (comment)

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Unit tests have been added or updated for any new or modified functionality

AI Usage

See our AI usage policy.

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

@codecov

codecov Bot commented Sep 27, 2026 •

Copy link
Copy Markdown

Bundle Report

Bundle size has no change ✅

@codecov

codecov Bot commented Sep 27, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 92.59259% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 39.30%. Comparing base (8ed7f5b) to head (d0a53ca).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/input.cpp 90.47% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #5821    +/-   ##
========================================
  Coverage   39.29%   39.30%            
========================================
  Files         120      120            
  Lines       27830    27836     +6     
  Branches    12189    12190     +1     
========================================
+ Hits        10936    10941     +5     
+ Misses      15429    14617   -812     
- Partials     1465     2278   +813     
Flag Coverage Δ
Alpine-aarch64 23.68% <82.60%> (+<0.01%) ⬆️
Alpine-x86_64 23.80% <82.60%> (+<0.01%) ⬆️
Archlinux 21.81% <100.00%> (ø)
FreeBSD-amd64 24.02% <80.76%> (+0.01%) ⬆️
Homebrew-macos-15 39.13% <82.60%> (+<0.01%) ⬆️
Homebrew-macos-26 39.44% <82.60%> (-0.01%) ⬇️
Homebrew-ubuntu-24.04 25.34% <82.60%> (+<0.01%) ⬆️
Linux-AppImage-aarch64 26.52% <82.60%> (+<0.01%) ⬆️
Linux-AppImage-x86_64 26.70% <82.60%> (+<0.01%) ⬆️
PowerShell 100.00% <ø> (ø)
Web-UI 66.31% <ø> (ø)
Windows-AMD64 30.90% <100.00%> (ø)
Windows-ARM64 25.94% <83.33%> (-0.01%) ⬇️
macOS-arm64 32.32% <80.76%> (+0.02%) ⬆️
macOS-x86_64 32.92% <80.76%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/input.h 50.00% <ø> (ø)
src/platform/common.h 61.19% <ø> (ø)
src/platform/virtualhid_input.cpp 97.68% <100.00%> (+<0.01%) ⬆️
src/platform/virtualhid_input.h 0.00% <ø> (ø)
src/input.cpp 56.61% <90.47%> (+0.09%) ⬆️

... and 27 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ed7f5b...d0a53ca. Read the comment docs.

@github-actions

github-actions Bot commented Sep 27, 2026 •

Copy link
Copy Markdown
Last Updated 2026-09-28 18:12:23 UTC
Source Run CI Run #5853
Commit d0a53cadca82bc1ff7a6fc93ff490dab1c3aae89

Screenshot Comparison

PR #5821 screenshots vs screenshots baseline.

Matrix: AppImage-aarch64

Image Baseline PR
sunshine_tray_initial.png
sunshine_tray_menu.png
sunshine_tray_pairing_request.png
sunshine_tray_paused.png
sunshine_tray_stopped.png
sunshine_tray_streaming.png
sunshine_tray_tooltip.png

Matrix: AppImage-x86_64

Image Baseline PR
sunshine_tray_initial.png
sunshine_tray_menu.png
sunshine_tray_pairing_request.png
sunshine_tray_paused.png
sunshine_tray_stopped.png
sunshine_tray_streaming.png
sunshine_tray_tooltip.png

Matrix: Windows-AMD64

Image Baseline PR
sunshine_tray_initial.png
sunshine_tray_menu.png
sunshine_tray_pairing_request.png
sunshine_tray_paused.png
sunshine_tray_stopped.png
sunshine_tray_streaming.png
sunshine_tray_tooltip.png

Matrix: Windows-ARM64

Image Baseline PR
sunshine_tray_initial.png
sunshine_tray_menu.png
sunshine_tray_pairing_request.png
sunshine_tray_paused.png
sunshine_tray_stopped.png
sunshine_tray_streaming.png
sunshine_tray_tooltip.png

Matrix: macOS-arm64

Image Baseline PR
sunshine_tray_initial.png
sunshine_tray_menu.png
sunshine_tray_pairing_request.png
sunshine_tray_paused.png
sunshine_tray_stopped.png
sunshine_tray_streaming.png
sunshine_tray_tooltip.png

Matrix: macOS-x86_64

Image Baseline PR
sunshine_tray_initial.png
sunshine_tray_menu.png
sunshine_tray_pairing_request.png
sunshine_tray_paused.png
sunshine_tray_stopped.png
sunshine_tray_streaming.png
sunshine_tray_tooltip.png

@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
1 New issue
1 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@ReenigneArcher
ReenigneArcher merged commit 2435fb4 into master Sep 29, 2026
83 of 84 checks passed
@ReenigneArcher
ReenigneArcher deleted the feat/MODIFIER_EXTENDED branch September 29, 2026 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant