fix: In Search of the Myreque corrections - #757
ryanxdennis wants to merge 1 commit into
Conversation
- 75 nails per rung instead of 10 (225 total), sourced from the 2005-2007 tip.it captures and an OSRS dump; Cyreg now asks for 6 planks, not 3, matching his "three for me, three for you" line and the journal. - Fix ^druid_complete -> ^druidspirit_complete in the Vanstrom requirement check, and the fourth Cyreg multi pointing at cyreg_myreque_enemy instead of cyreg_vigilante. - Add hammering synth on rung repair, drop a stray unreachable mes() and an unused npc uid, and use ~route_get_question for the scholar question header. - Clear the quest's scratch varbits on completion, leaving the bridge rungs repaired. - Add talk-to fallbacks for Sani and Harold once the cutscene state is set. - Replace the "MISSING journal for 67" and "7th question" TODOs with notes explaining why neither applies here, plus timing notes on the repair.
|
It doesn't seem too likely that it would have been 75 nails per rung, before construction was released, the the only way to make nails was by smithing steel bars (2 per bar), meaning it'd require 113 bars just for this quest after construction release, they increased the nails required in most quests to compensate for them being much easier to obtain, this is probably when it was increased to 225 (other quests in this version like dragon slayer and horror from the deep are also affected) it's also referenced as 30 (total) on nomad, sals, runevillage in 2005 https://web.archive.org/web/20050323140227/http://www.nomadgaming.com/index.php?page=rs2_insearchofthemyreque |
Very interesting and would make sense (although note it does clash with the tip.it guides). Feel free to modify this PR as needed (or happy to modify it myself if we want to end up going with the less nail approach). The rest of the fixes should be solid :). I did dump the full quest with an RSProx play-thru but a lot had changed unfortunately. |
Looking into to it a bit more... it looks like the nails change may have been earlier, probably with https://oldschool.runescape.wiki/w/Update:Zogre_Flesh_Eaters, which introduced bronze-rune nails. Which would explain why tip.it is showing 225 (made using 15 bars). Checking the sals guide for dragon slayer and this quest from late 2005 also show the new numbers |
That seems to be the key, that the correct amount of nails is what can be made with 15 bars. Good thinking. |
3 participants
A pass over In Search of the Myreque. Mostly small stuff I ran into playing through it, but the plank/nail counts and a couple of wrong identifiers are real bugs.
Bridge repair costs
~routequest_try_fix_rungwanted 10 nails per rung and Cyreg asked for 3 planks. Should be 75 nails per rung (225 total) and 6 planks.The tip.it guide (last updated 10 Aug 2005, same line in the 2005-11-10, 2006-06-09 and 2007-06-06 captures) says "Each part will take a plank and 75 steel nails.", and lists "225 steel nails (make from 15 steel bars), 6 planks". global-rs 2008/03 agrees and an OSRS dump goes 225 > 150 > 75 > 0. Only runehq 2005/01 disagrees. For planks, Cyreg's own line is "I need three and you need three" and the journal already checks for 6.
Bugs
routequest_vanstorm.rs2checked^druid_complete. The constant is^druidspirit_complete.cyreg_interrogate_multi_fourthpagesent the vigilante option tocyreg_myreque_enemyinstead ofcyreg_vigilante.oploc5,swamp_bridge1case 1 had a trailing "This bridge rung already looks fixed..." after the repair branch. Unreachable in one path, wrong in the other.route_cutscene.rs2defined$sani_uidand never used it.~route_get_question($q).else, so talking to them during^routequest_enter_cutscenedid nothing. They now give the same "This person isn't able to talk to you at this time." as Radigad/Polmafi/Ivan.Other
queue,routequest_completenow zeroes the quest's scratch vars, leaving%bridgerung1/2/3alone. OSRS zeroes the whole varp then writes the rungs back to 1, so this gets to the same place.Rung repairs now play a synth alongside the smithing anim, three times at 0/20/40 like the dump. I couldn't find a 377 equivalent of the dump's sound, so
hammering(already in the repo) stands in. Flagged as a guess.Both TODOs are now explanations instead. Varp value 67 is OSRS-only and never observable here, since
route_veliaf_hurtzsets^routequest_enter_cutscenein the same tick it deletes the weapons. The "7th question" one: tip.it's 2005-2007 captures list exactly six, and while later guides add more, nobody recorded the wrong options, so adding them means inventing distractors.Also fixed missing trailing newlines on three files while I was in them.