Repository navigation
Publish the Android module to Maven Central and check its version at start - #16
Merged
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## b1-bundlers #16 +/- ##
===============================================
+ Coverage 92.09% 92.16% +0.07%
===============================================
Files 33 33
Lines 2883 2910 +27
Branches 38 39 +1
===============================================
+ Hits 2655 2682 +27
Misses 201 201
Partials 27 27 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…hout the handshake
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



This makes the crate's Android module available as
io.github.lucacappelletti94:pushups-androidon Maven Central, at the same version as the crate, for Gradle apps that would rather add one dependency than include the module's sources the way #15 does throughcargo metadata. A separate Gradle project builds and signs the AAR with the toolchain the module already uses, so its Kotlin stays readable by the Kotlin 2.0 thatdx0.7 apps compile with, and a workflow uploads it to the Central Portal on av<version>tag. A one-off dry run had Central validate the signed bundle and then dropped it, so nothing is published yet.Because the Kotlin calls into Rust exports that belong to one crate version, the module now checks at start that the app's crate is its own version, through one export whose signature never changes. On a mismatch push stays off and
installreturns a newError::AndroidModuleMismatchnaming both versions, where an AAR of one release beside a crate of another used to fail somewhere in JNI. A new instrumented variant covers it, and CI also checks that the module's version followsCargo.toml.The winit example can now take the module either way, and its emulator job runs the real-push proof against both the sources and the AAR. This stacks on #15.