Repository navigation
Build the winit example for the web and push to it in Chrome in CI - #24
Merged
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #24 +/- ##
=======================================
Coverage 92.17% 92.17%
=======================================
Files 33 33
Lines 2912 2912
Branches 39 39
=======================================
Hits 2684 2684
Misses 201 201
Partials 27 27 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
LucaCappelletti94
force-pushed
the
x1-winit-web
branch
3 times, most recently
from
October 12, 2026 22:11
7216989 to
98222af
Compare
LucaCappelletti94
force-pushed
the
x1-winit-web
branch
from
October 12, 2026 22:12
98222af to
dc0620e
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The winit example gains a Trunk entry in both worker modes, the way
examples/yewfrom #15 builds, with the native code split bycfgand unchanged. The newexample-winit-webjob builds it and runsci/web/example.mjswith real pushes, as the Yew job does.It passed in Chrome and Firefox in both modes, with a push to the open page and one drained by the next page.