Repository navigation
Give the winit and Tauri Android examples the brand launcher icon - #80
Merged
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #80 +/- ##
=======================================
Coverage 94.52% 94.52%
=======================================
Files 45 45
Lines 5937 5937
Branches 61 61
=======================================
Hits 5612 5612
Misses 285 285
Partials 40 40 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The winit example installed on Android with the system's default icon, because its manifest named none, and the Tauri example with Tauri's logo, which
tauri android initwrites into the generated project. Both now show the pushups mark as an adaptive icon on the brand navy. The winit app carries the rendered mipmaps, whichassets/brand/render.shderives from a new foreground variant that keeps the mark inside the circle every launcher mask keeps, and the Tauri job runstauri iconwith the same sources after generating the project.CI never built the Tauri example for iOS, so the push entitlement and the
remote-notificationbackground mode thattauri-plugin-pushupsadds to the generated Xcode project went unchecked. The Apple examples job now builds it unsigned for the device and checks the exported background handler, the background mode, the entitlement and the brand app icon.The Dioxus example on Android and the Dioxus, tao and winit examples on iOS still install without the brand icon, because
dx0.7.10 ignores the configured icon on both platforms. DioxusLabs/dioxus#5901 fixes iOS, and DioxusLabs/dioxus#5693 fixes Android.