Skip to content

Give the winit and Tauri Android examples the brand launcher icon - #80

Merged
LucaCappelletti94 merged 2 commits into
mainfrom
examples/app-icons
Oct 26, 2026
Merged

LucaCappelletti94 merged 2 commits into
mainfrom
examples/app-icons

Conversation

@LucaCappelletti94

@LucaCappelletti94 LucaCappelletti94 commented Oct 26, 2026 •

Copy link
Copy Markdown
Owner

The winit example installed on Android with the system's default icon, because its manifest named none, and the Tauri example with Tauri's logo, which tauri android init writes into the generated project. Both now show the pushups mark as an adaptive icon on the brand navy. The winit app carries the rendered mipmaps, which assets/brand/render.sh derives from a new foreground variant that keeps the mark inside the circle every launcher mask keeps, and the Tauri job runs tauri icon with the same sources after generating the project.

CI never built the Tauri example for iOS, so the push entitlement and the remote-notification background mode that tauri-plugin-pushups adds to the generated Xcode project went unchecked. The Apple examples job now builds it unsigned for the device and checks the exported background handler, the background mode, the entitlement and the brand app icon.

The Dioxus example on Android and the Dioxus, tao and winit examples on iOS still install without the brand icon, because dx 0.7.10 ignores the configured icon on both platforms. DioxusLabs/dioxus#5901 fixes iOS, and DioxusLabs/dioxus#5693 fixes Android.

@coderabbitai

coderabbitai Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Central YAML; Path: .coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: ffa71367-a48f-44f0-b667-5bde5bd3c40d
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Oct 26, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.52%. Comparing base (fc87b2c) to head (b85bd2a).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #80   +/-   ##
=======================================
  Coverage   94.52%   94.52%           
=======================================
  Files          45       45           
  Lines        5937     5937           
  Branches       61       61           
=======================================
  Hits         5612     5612           
  Misses        285      285           
  Partials       40       40           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@LucaCappelletti94
LucaCappelletti94 merged commit 63345e4 into main Oct 26, 2026
38 checks passed
@LucaCappelletti94
LucaCappelletti94 deleted the examples/app-icons branch October 26, 2026 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant