Skip to content

Show the real notification permission in the examples and add open_notification_settings - #81

Merged
LucaCappelletti94 merged 10 commits into
mainfrom
examples/permission-state
Oct 27, 2026
Merged

LucaCappelletti94 merged 10 commits into
mainfrom
examples/permission-state

Conversation

@LucaCappelletti94

@LucaCappelletti94 LucaCappelletti94 commented Oct 26, 2026 •

Copy link
Copy Markdown
Owner

The examples always showed "Allow notifications", even once the permission was granted. Each now reads permission_status at start and whenever it comes back to the foreground, offers the button only while a prompt can still change the answer, and shows an "Open Settings" button while notifications are off on iOS, Android, macOS and Windows.

That button calls a new public function, pushups::open_notification_settings(). It opens this app's notification settings: the iOS notification settings URL, Android's app notification settings (the app details screen below Android 8), the macOS Notifications pane, and ms-settings:notifications on Windows. It returns Error::Unsupported on Linux and the web, and Error::Platform when the device has nothing to open, which an Android test checks by disabling the settings app.

The HTML examples now share one look from examples/support: a status card with the transport, the permission and a shortened token with a Copy button, a card per push with its time, a started-the-app badge and the delivery delay, and a Copy log button on native builds too. winit and tao draw the same status block and a compact line per push. The page padding keeps clear of the iPhone's Dynamic Island.

The Android emulator tests now also run on API 24, the module's minSdk. There the UnifiedPush variants are skipped, since ntfy needs Android 8, and APKs are pushed whole before installing, because Android 7 stalled on streamed installs. Every device step in ci/android/run.sh now has a time bound and prints the screen and the system log when it hangs.

On an iPhone, the Tauri example showed the status card and the push cards, and turning notifications off, tapping Open Settings and turning them back on went through as expected. The README screenshots still show the previous UI.

@LucaCappelletti94 LucaCappelletti94 added the enhancement New feature or request label Oct 26, 2026
@coderabbitai

coderabbitai Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Central YAML; Path: .coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 9ae09c51-964e-4499-a560-13864c84b9ad
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 89.18919% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 94.49%. Comparing base (b85bd2a) to head (1b5aa09).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
android/src/main/kotlin/rs/pushups/Pushups.kt 75.00% 0 Missing and 3 partials ⚠️
src/android.rs 93.75% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #81      +/-   ##
==========================================
- Coverage   94.52%   94.49%   -0.04%     
==========================================
  Files          45       45              
  Lines        5937     5974      +37     
  Branches       61       63       +2     
==========================================
+ Hits         5612     5645      +33     
- Misses        285      286       +1     
- Partials       40       43       +3     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@LucaCappelletti94
LucaCappelletti94 merged commit e1da1f7 into main Oct 27, 2026
39 checks passed
@LucaCappelletti94
LucaCappelletti94 deleted the examples/permission-state branch October 27, 2026 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant