Repository navigation
Show a Web Push token on the examples' status card as its endpoint's host and tail - #83
Merged
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #83 +/- ##
=======================================
Coverage 94.49% 94.49%
=======================================
Files 45 45
Lines 5974 5974
Branches 63 63
=======================================
Hits 5645 5645
Misses 286 286
Partials 43 43 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The examples' status card cut every token line to its first and last 8 characters. For a Web Push subscription, that line is the serialised subscription JSON, so on Linux and the web the card read
subscrip...v2M4g"}}, the start of the field name and the end of theauthkey.A Web Push token now shows as its endpoint's host and the last 8 characters of the endpoint's path, such as
fcm.googleapis.com...12345678orntfy.sh...Xyz12345. The copy button and the loggedsubscription=line still carry the full subscription.