Skip to content

Keep clone credentials out of process arguments - #224

Merged
LuisPalacios merged 2 commits into
mainfrom
fix/161-token-free-clone-argv
Nov 14, 2026
Merged

LuisPalacios merged 2 commits into
mainfrom
fix/161-token-free-clone-argv

Conversation

@LuisPalacios

Copy link
Copy Markdown
Owner

Closes #161

What changed

Token-authenticated clones now use canonical URLs and an isolated credential-store helper, keeping tokens out of process arguments. Credential preparation errors stop cloning before Git starts.

The helper handles quoted paths correctly and preserves GitLab usernames and HTTP/HTTPS matching. Failed clones preserve any remaining destination and report its location.

Test plan

  • Go vet, focused tests and full health checks.
  • Builds and version smoke checks on macOS ARM, Windows and Linux.
  • Manual Forgejo and GitLab token-authenticated clones.
  • Verify canonical origins, isolated helpers and credential file permissions.
  • macOS Intel verification: host unavailable.

Use the account credential-store helper before cloning, preserve GitLab usernames and URL protocols, and quote helper paths consistently. Report failed clone destinations without modifying them.

Closes #161
@LuisPalacios
LuisPalacios merged commit d633449 into main Nov 14, 2026
1 check passed
@LuisPalacios
LuisPalacios deleted the fix/161-token-free-clone-argv branch November 14, 2026 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Phase 1] Token-free clone argv using the existing store-file helper

1 participant