Repository navigation
Keep clone credentials out of process arguments - #224
Merged
Merged
Conversation
Use the account credential-store helper before cloning, preserve GitLab usernames and URL protocols, and quote helper paths consistently. Report failed clone destinations without modifying them. Closes #161
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #161
What changed
Token-authenticated clones now use canonical URLs and an isolated credential-store helper, keeping tokens out of process arguments. Credential preparation errors stop cloning before Git starts.
The helper handles quoted paths correctly and preserves GitLab usernames and HTTP/HTTPS matching. Failed clones preserve any remaining destination and report its location.
Test plan