Skip to content

Add riscv64 architecture to Docker workflow platform check #352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
eshattow wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add riscv64 architecture to Docker workflow platform check #352

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/docker.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,7 @@ jobs:
elif . == "arm64v8" then "linux/arm64"
elif . == "arm32v7" then "linux/arm/v7"
elif . == "i386" then "linux/386"
elif . == "riscv64" then "linux/riscv64"
else empty
end
)
Expand Down
2 changes: 1 addition & 1 deletion dist-workspace.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ ci = "github"
# The installers to generate for each app
installers = ["shell"]
# Target platforms to build apps for (Rust target-triple syntax)
targets = ["aarch64-unknown-linux-gnu", "x86_64-unknown-linux-gnu", "aarch64-unknown-linux-musl", "x86_64-unknown-linux-musl"]
targets = ["aarch64-unknown-linux-gnu", "x86_64-unknown-linux-gnu", "aarch64-unknown-linux-musl", "x86_64-unknown-linux-musl", "riscv64gc-unknown-linux-gnu", "riscv64gc-unknown-linux-musl"]
# Path that installers should place binaries in
install-path = "CARGO_HOME"
# Whether to install an updater program
Expand Down
2 changes: 1 addition & 1 deletion docker/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ The workflow has three stages:
- Builds exactly one canonical image per `(cargo-chef version, group key)`:
- `<cargo-chef version>-base-<group_key_tag>`
- Uses one representative Rust alias as build input (prefers versioned tags when present).
- Uses upstream `Architectures` to set `buildx` platforms, limited to `amd64`, `arm64`, `arm/v7`, and `386`.
- Uses upstream `Architectures` to set `buildx` platforms, limited to `amd64`, `arm64`, `arm/v7`, `riscv64`, and `386`.
- Skips if the canonical image already exists.

3. Publish aliases per group (`publish_group_aliases`)
Expand Down