Redesign export video view to match calendar video player layout - #43
Open
LukeNeedham wants to merge 3 commits into
Open
Redesign export video view to match calendar video player layout#43LukeNeedham wants to merge 3 commits into
LukeNeedham wants to merge 3 commits into
Conversation
Original TODO: the export video view page needs to be updated to follow the same design as the calendar video player - video takes full width, height is driven by aspect ratio as from repo, video aligned to bottom, black toolbar aligned to top fills remaining height. toolbar contains back button, and name of export (if applicable) is centered, with the date range in small text underneath (or centered if there is no name). pause, mute buttons float aligned to bottom-left, share button floats aligned to bottom-right. - Add nullable `name` to `ExportedVideo`, threaded through from `SavedExport` and the fresh export name entered on the create screen. - Rebuild `ExportDiaryViewPageContent` as a Column with a black weight(1f) toolbar on top (back button + centered name/date range) and an aspect-ratio-sized video below, mirroring `CalendarScroller`. - Float mute/pause buttons bottom-left and the share button bottom-right over the video, matching the calendar day bottom bar styling.
|
App apk at:
|
The toolbar sits directly on the black background rather than over video, so its back button doesn't need the "glass" translucent-panel treatment used for controls that float over video content.
…cjhu # Conflicts: # TODO.md # app/src/main/java/com/lukeneedham/videodiary/ui/feature/exportdiary/create/ExportDiaryCreateViewModel.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original TODO
Summary
ExportDiaryViewPageContentas aColumnwith a blackweight(1f)toolbar on top and an aspect-ratio-sized video below, mirroringCalendarScroller's layout (video full width, height driven byaspectRatio, video aligned to bottom, toolbar filling the remaining height above).ExportDiaryViewToolbar) with a back button and a centered title area: the export name (if present) centered with the date range in small text underneath, or just the date range centered if there's no name.CalendarDayBottomBar's styling (GlassIconButton).name: String?to theExportedVideodomain model so the export's name can reach this screen, threading it through fromSavedExport.name(when viewing a previously saved export) and from the trimmed export name entered on the create screen (when viewing a freshly created export).MockDataExportDiaryViewwith named/unnamed preview data and added a preview for the unnamed case.Test plan
./gradlew compileDebugKotlin./gradlew assembleDebug testGenerated by Claude Code