Adds auth bypass request from #134 - #214
Open
0xv1n wants to merge 2 commits into
Open
Conversation
When UI_USERNAME and UI_PASSWORD are both empty the login screen was pure friction: NewAuthStore hashed the empty string and CompareCreds accepted empty input, so any visitor signed in by clicking the button with both fields blank. Auth is now skipped entirely in that case. RequireAuth returns the handler unwrapped, /api/ui/auth/status reports auth_disabled so the frontend routes straight into the app, and the server logs a warning at startup that it is running unauthenticated. The Settings header shows an "Auth disabled" chip in place of "Sign out". Behaviour is unchanged when credentials are configured. CSRF is unaffected: SessionManager.Handle verifies tokens on every mutating request independently of auth. Refs LumePart#134
On a Windows checkout with core.autocrlf=true, docker/start.sh gets CRLF endings. The shebang then carries a trailing carriage return and the built image dies immediately with: exec /start.sh: no such file or directory Pin *.sh to LF so the container entrypoint survives a Windows build.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
UI_USERNAMEandUI_PASSWORDare both unset, weskip the login screen entirely rather than rendering a form that already accepted empty input, so single-admin instances on trusted networks land straight in the UI (refs #134).Behavior is unchanged when credentials are configured, CSRF stays enforced either way, and the unauthenticated state is never silent: the server logs a warning at startup and the header shows an "Auth disabled" chip in place of "Sign out". The Auth disabled is just a visuall artifact to keep a consistent header styling but honestly probably unnecessary.
Smaller change is another commit to force LF via gitattributes if you're a degenerate like me deving on a windows machine and have auto crlf on. shouldnt impact nix/mac devs