Repository navigation
Fix MESSI top-k returning duplicate series - #76
Merged
Merged
Conversation
The approximate phase scans one leaf to seed the best-so-far queue, and the parallel phase then scans every leaf again, including that one. The L2 and DTW leaf scans inserted with pqueue_bsf_insert, which does not check whether a position is already in the queue, so series from the seeded leaf entered the k-NN list twice or more and displaced real neighbours. Use pqueue_bsf_insert_no_dup_position (already used by Odyssey) at the four insertion sites in Messi.cpp. On 200k clustered 128-d vectors with k=10, the fraction of true top-10 ids returned rises from 0.81 to 0.9998 and no query returns duplicates. Add a regression test that fails without the change. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.