Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Coconut exact top-k previously started with an empty heap, ran queries serially, and reopened leaf files for each candidate vector. This change seeds refinement from distinct records near the query's sortable-SAX key, honors the requested query workers, and reads complete candidate leaves into private query buffers. Exact refinement still considers every unseeded SAX summary and the live insertion buffer.
Top-k and range now share checked leaf reads, including partial final leaves; missing or truncated reads raise an error instead of producing incomplete results. Contiguous build inputs are borrowed only while writing the index. Regression tests cover FAISS ground truth, streaming inserts, worker counts, ties, directory endpoints, oversized k, input lifetime, invalid configuration, and failed reads.
The README and pinned upstream audit explain the remaining storage differences: the key directory is resident, and inserted records remain in an unmerged buffer. This does not implement Berkeley DB storage or Coconut-LSM flush/merge.
/scripts/experiments/is added to.gitignore; experiment scripts, datasets, and unrelated MESSI changes are excluded.Validation:
BUILD_COCONUT=ON.test_coconut_topk_pyandtest_streaming_pypassed (five Coconut checks and four existing streaming checks).BUILD_COCONUT=OFF, with MPI, CUDA, FFTW-backed algorithms, and C++ FAISS disabled.git diff --checkpassed.