cardigan: update to 0.1.0-alpha.4 - #1421
Closed
phjeltman wants to merge 6 commits into
Closed
Conversation
phjeltman
requested review from
Kaliumhexacyanoferrat and
MDA2AV
as code owners
September 1, 2026 05:54
Contributor
Author
|
/benchmark-multiple --save |
Contributor
|
👋 Benchmark request received. A collaborator will review and approve the run. |
Contributor
Benchmark ResultsFramework:
Full log |
Contributor
Author
|
/benchmark-multiple -f cardigan-json-tls,cardigan-h2,cardigan-h2c,cardigan-grpc,cardigan-grpc-tls --save |
Contributor
|
👋 Benchmark request received. A collaborator will review and approve the run. |
Collaborator
|
/benchmark-multiple -f cardigan-json-tls,cardigan-h2,cardigan-h2c,cardigan-grpc,cardigan-grpc-tls --save |
Contributor
|
👋 Benchmark request received. A collaborator will review and approve the run. |
Collaborator
|
@phjeltman ah sorry, those are acutal own entries - is there a reason we cannot merge them into a single framework entry (or maybe 2-3)? |
Contributor
Benchmark ResultsFrameworks: 5 | Test: ✅
|
| Test | Conn | RPS | CPU | Mem | Δ RPS | Δ Mem |
|---|---|---|---|---|---|---|
| json-tls | 4096 | 1,763,949 | 6176.4% | 1.8GiB | +12.5% | -68.4% |
✅ cardigan-h2
| Test | Conn | RPS | CPU | Mem | Δ RPS | Δ Mem |
|---|---|---|---|---|---|---|
| baseline-h2 | 256 | 15,138,548 | 1644.1% | 1.2GiB | +4.0% | -76.0% |
| baseline-h2 | 1024 | 14,491,128 | 1658.8% | 2.3GiB | +4.4% | -60.3% |
| static-h2 | 256 | 1,189,184 | 6176.6% | 1.5GiB | +50.4% | -74.1% |
| static-h2 | 1024 | 1,046,258 | 6159.9% | 2.7GiB | +42.7% | -55.0% |
✅ cardigan-h2c
| Test | Conn | RPS | CPU | Mem | Δ RPS | Δ Mem |
|---|---|---|---|---|---|---|
| baseline-h2c | 256 | 15,224,612 | 1388.0% | 1.3GiB | +0.4% | -76.4% |
| baseline-h2c | 1024 | 14,860,276 | 1339.6% | 2.5GiB | -1.2% | -55.4% |
| baseline-h2c | 4096 | 14,053,901 | 1358.8% | 5.9GiB | +0.9% | +1.7% |
✅ cardigan-grpc
| Test | Conn | RPS | CPU | Mem | Δ RPS | Δ Mem |
|---|---|---|---|---|---|---|
| unary-grpc | 256 | 7,091,284 | 1406.6% | 2.0GiB | -1.2% | -62.3% |
| unary-grpc | 1024 | 6,901,980 | 1654.3% | 3.3GiB | -2.0% | -45.9% |
✅ cardigan-grpc-tls
| Test | Conn | RPS | CPU | Mem | Δ RPS | Δ Mem |
|---|---|---|---|---|---|---|
| unary-grpc-tls | 256 | 6,788,514 | 1484.9% | 2.1GiB | -2.6% | -63.2% |
| unary-grpc-tls | 1024 | 6,663,596 | 1763.3% | 3.8GiB | -0.5% | -43.3% |
Contributor
Author
|
@Kaliumhexacyanoferrat Yeah I should definitely merge them into one entry, this setup is a bit messy. I will do that in next PR. Thanks! |
Contributor
Author
|
/benchmark-multiple --save |
Contributor
|
👋 Benchmark request received. A collaborator will review and approve the run. |
Contributor
|
|
Collaborator
|
/benchmark-multiple --save |
Contributor
|
👋 Benchmark request received. A collaborator will review and approve the run. |
Collaborator
|
/benchmark-multiple --save |
Contributor
|
👋 Benchmark request received. A collaborator will review and approve the run. |
Collaborator
|
So we obviously confused our benchmark workflow here … /benchmark -f cardigan --save |
Contributor
|
👋 Benchmark request received. A collaborator will review and approve the run. |
Contributor
Benchmark ResultsFramework:
Full log |
Contributor
Author
|
Hmm, consolidated entry looks meh in terms of memory. I will improve this a bit and be back with an alpha.5. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Bump Cardigan to
dev.cardigan:cardigan:0.1.0-alpha.4and update benchmark fixtures.