Skip to content

feat: implement Soroban transaction validation, rebuild, confirmation, and review services - #1073

Merged
mijinummi merged 4 commits into
MDTechLabs:mainfrom
eyooTech:newiis
Aug 28, 2026
Merged

feat: implement Soroban transaction validation, rebuild, confirmation, and review services#1073
mijinummi merged 4 commits into
MDTechLabs:mainfrom
eyooTech:newiis

Conversation

@eyooTech

Copy link
Copy Markdown
Contributor

Summary

This PR implements transaction reliability, validation, confirmation, and review functionality for Soroban and Stellar bridge transactions.

Changes

  • Implemented a Soroban transaction rebuild service for rebuilding stale or recoverable failed transactions using refreshed network data.
  • Preserved original user transfer intent during transaction rebuilds while refreshing sequence numbers, resource estimates, and quote data.
  • Added protection against rebuilding non-recoverable transaction failures.
  • Implemented a Soroban contract allowance validator to validate available token allowance before contract-based transfers.
  • Added insufficient allowance detection with required and available allowance values exposed through validation results and errors.
  • Implemented a configurable Stellar bridge execution confirmation policy.
  • Added support for configurable minimum confirmation thresholds and finalized transaction detection.
  • Exposed normalized confirmation state for execution and transaction consumers.
  • Implemented a normalized Stellar wallet transaction review model.
  • Added transfer source and destination details, transfer amounts, estimated fees, and contract interaction information.
  • Added transaction warnings for unusual or incomplete parameters.
  • Added tests covering rebuild behavior, non-recoverable failures, allowance validation, confirmation thresholds, finalized states, transaction review normalization, fees, contract interactions, and warnings.

Issues

Closes #991
Closes #993
Closes #994
Closes #995

@drips-wave

drips-wave Bot commented Aug 27, 2026

Copy link
Copy Markdown

@eyooTech Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@mijinummi
mijinummi merged commit b17e2e0 into MDTechLabs:main Aug 28, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants