feat(soroban): implement 4 analyzer rules (#775 #776 #777 #778) - #784
Merged
mijinummi merged 2 commits intoAug 28, 2026
Merged
Conversation
…abs#776, MDTechLabs#777, MDTechLabs#778) - MDTechLabs#775 UnnecessaryCloningRule: detects avoidable .clone() calls on Soroban types (Vec, Map, Bytes, String, Address) and flags functions with multiple clones or clones of expensive host-object types. - MDTechLabs#776 MemoryAllocationRule: detects repeated heap allocations within a function and allocations that appear inside loop bodies, both of which inflate metered CPU/memory resource consumption. - MDTechLabs#777 InefficientErrorConstructionRule: detects string formatting, heap allocations, and repeated Err() constructions on error paths that add avoidable overhead on every failing invocation. - MDTechLabs#778 EventEmissionCostRule: detects frequent event emission, large payload types (Vec/Map/Bytes/String), and in-loop event emissions that multiply per-iteration ledger footprint costs. All four rules implement SorobanRule, are registered in SorobanRuleEngine::add_default_rules(), and are exported from soroban/mod.rs and lib.rs. Closes MDTechLabs#775, MDTechLabs#776, MDTechLabs#777, MDTechLabs#778
|
@bobaivigitalpoint-ui Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Collaborator
|
please kindly fix conflict @bobaivigitalpoint-ui |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements four new Soroban static-analysis rules.
Rules
All four rules implement SorobanRule, are registered in SorobanRuleEngine::add_default_rules(), and exported from soroban/mod.rs and lib.rs.
Closes #775
Closes #776
Closes #777
Closes #778