feat(soroban): call graph + serialization cost analyzers (#771, #772, #773, #774) - #786
Merged
mijinummi merged 2 commits intoAug 28, 2026
Conversation
…abs#771, MDTechLabs#772, MDTechLabs#773, MDTechLabs#774) - callgraph-analyzer.ts: builds call graph, detects nested chains (MDTechLabs#771), cross-contract calls (MDTechLabs#772), and redundant identical calls (MDTechLabs#773) - serialization-analyzer.ts: detects repeated (de)serializations, unnecessary type conversions, and large serialized structs (MDTechLabs#774) - Rule wrappers in packages/rules/soroban/src/calls/ and .../serialization/ - Re-export everything from soroban src/index.ts Closes MDTechLabs#771, closes MDTechLabs#772, closes MDTechLabs#773, closes MDTechLabs#774
|
@monique-7arch Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Collaborator
|
please kindly fix conflict @monique-7arch |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements four assigned Soroban analyzer issues in a single PR.
Changes
Call Graph Analyzer (
packages/rules/soroban/src/analyzer/callgraph-analyzer.ts)env.invoke_contract,Client::new, etc.)#771 — Detect Expensive Nested Soroban Calls
packages/rules/soroban/src/calls/nested-calls-rule.ts#772 — Implement Soroban Cross-Contract Call Analyzer
packages/rules/soroban/src/calls/cross-contract-calls-rule.ts#773 — Detect Redundant Soroban Contract Calls
packages/rules/soroban/src/calls/redundant-calls-rule.ts#774 — Implement Soroban Serialization Cost Analyzer
packages/rules/soroban/src/analyzer/serialization-analyzer.tspackages/rules/soroban/src/serialization/serialization-cost-rule.tsto_xdr/from_xdr/serialize calls on the same valueAll new modules are re-exported from
packages/rules/soroban/src/index.ts.Closes #771
Closes #772
Closes #773
Closes #774