Add design docs for state dependency graph, dataflow analysis, unused computation, and redundant copies - #855
Merged
mijinummi merged 1 commit intoAug 28, 2026
Conversation
|
@AbdulmujibOladayo Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds design/spec docs for four related Soroban static-analysis features, grounding each in the repo's existing analyzer and rule conventions (
src/analysis/dependency-graph/,src/graphs/stellar/call-graph/,packages/rules/soroban/src/).Closes #833
Builds a state dependency graph (
src/analysis/state-graph/) modeling Sorobanenv.storage()reads, writes, and the computations connecting them, so later rules can reason about non-local dependencies instead of scanning line-by-line.Closes #834
Specifies a dataflow analyzer (
src/analysis/dataflow/) that tracks variable definitions, uses, function arguments, and return values across basic control-flow paths, feeding both #835 and #836.Closes #835
Defines
SorobanUnusedComputationRule(packages/rules/soroban/src/unused-computation-check.ts), which flags computed values that are bound but never subsequently read, returned, or passed as an argument, using the #834 dataflow output.Closes #836
Defines
SorobanUnnecessaryCopyRule(packages/rules/soroban/src/unnecessary-copy-check.ts), which flags redundantlet x = y.clone();copy chains while explicitly excluding function-parameter-sourced values to avoid ownership-related false positives.