Repository navigation
K13.1: expire buys whose deposit never reaches 1Click - #136
Merged
Merged
Conversation
A buy still PENDING_DEPOSIT 30 minutes after it was sent counted as in flight forever and blocked every later buy of the plan. Closes #127
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First fix from the pre-launch review (ROADMAP Phase 13).
Problem: a buy still
PENDING_DEPOSITat 1Click counted as in flight forever, soscheduleBuysreturnedin_flightfor that vault on every pass and the plan never bought again.Fix:
pollBuysmarks itexpiredonce it's 30 minutes old (quote deadline is 10 minutes, plus margin), with a note. Buys that 1Click has seen (KNOWN_DEPOSIT_TXor later) are never expired.Tests: 3 new (expires and frees the plan; recent buy keeps waiting; seen deposit never expires). 134 total.
Also in this PR: the alternative demo video script (separate commit). Docs: README status, ARCHITECTURE §4.4, ROADMAP Phase 13 (new, issues #127–#135).
Closes #127