Repository navigation
K13.2: keep buys in flight when NEAR gives no clear result - #137
Merged
Merged
Conversation
A timeout after the transaction was sent marked the buy failed, and History said nothing was spent while the USDC may already have left. Closes #128
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Second fix from the pre-launch review.
Problem: any error from
execute_buymarked the buyfailed, so History said "Nothing spent". If the RPC timed out after the transaction landed, the USDC had in fact left.Fix:
isClearTxFailure()(lib/near/vault.ts): only a contract refusal, a failed action or a rejected transaction counts as a clear failureBuyOutcomeUnknownErrorfor everything elsescheduleBuyskeeps that buysentwith a note and alerts;pollBuyssettles it from 1Click's status, and K13.1's 30-minute expiry covers a deposit that never arrivedTests: 3 new (scheduler keeps the row in flight and blocks a second buy; classifier for clear failures; classifier for timeouts/network). 137 total.
Docs: README status, ARCHITECTURE §4.4, ROADMAP.
Closes #128