Repository navigation
K13.4: sign-out ends every session - #138
Merged
Merged
Conversation
Sign-out only cleared the browser cookie, so a copied session token kept working for 7 days. Closes #130
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix 3 from the pre-launch review (auth).
Problem: sign-out only cleared the cookie. A copied or stolen session token kept working for its full 7 days.
Fix:
DELETE /api/sessionsetsusers.sessions_valid_after(migration 0003, one nullable column)requireUserand the demo routes reject sessions issued before itTests: route test signs in, signs out with the same cookie, checks it now gets 401, and that a fresh sign-in works. 138 total.
Also (separate commit): CI retries the
cargo-neardownload and falls back to building it from crates.io, because GitHub's release downloads kept answering 504 and failing the contract job.Docs: README status, ARCHITECTURE §4.1 and §5, ESSENTIALS, ROADMAP.
Closes #130