Repository navigation
K13.5: keep previews and the demo off the production database - #139
Merged
Merged
Conversation
The Neon integration gives Preview and Development the production DATABASE_URL, and every build ran migrations against it. Closes #131
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix 4 from the pre-launch review (user data).
Problem: the Neon integration set the production
DATABASE_URLfor Production, Preview and Development, andvercel-buildran migrations on every build. A preview deploy would migrate and write the production database;vercel env pullfollowed bypnpm demowould point the local demo at it too.Fix:
scripts/vercel-build.mjs: migrations only whenVERCEL_ENV=productiondatabaseUrlFor()inlib/db/client.ts: on Preview/Development, ignoreDATABASE_URL; usePREVIEW_DATABASE_URLor refuse to start with a clear messagepnpm democlearsDATABASE_URL(checked: Next keeps the empty value over.env.local)Done in code rather than by removing the variable on Vercel: it's managed by the Neon integration, and a wrong
env rmcould take production's setting with it.Tests: 3 new for
databaseUrlFor. Docs: README status, ARCHITECTURE hosting, ESSENTIALS,.env.example, ROADMAP.Closes #131