Repository navigation
K13.7: rate limits shared across serverless instances - #140
Merged
Merged
Conversation
Counters lived in each instance's memory, so on the hosted app the limits barely applied, and the map never shrank. Closes #133
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix 5 from the pre-launch review (abuse).
Problem:
lib/server/rateLimit.tskept counters in memory. On Vercel each instance has its own memory, so floods spread across instances barely hit the limits (quote requests reached 1Click from our IP), and the map was never cleaned.Fix:
rate_limitstable (migration 0004): one fixed window per keyINSERT … ON CONFLICT DO UPDATE … RETURNING countper request: new window → 1, otherwise +1, refused past the limitcleanupDemoalso drops counters older than a dayTests: 5 new (limit, window reset, per-key, burst of 8 against a limit of 5 gives exactly 5 allowed, cleanup). 146 total.
Docs: README status, ARCHITECTURE §5 and §7, ESSENTIALS, ROADMAP.
Closes #133